Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding in E.sendOnly() #1865

Merged
merged 21 commits into from
Oct 17, 2020
Merged

adding in E.sendOnly() #1865

merged 21 commits into from
Oct 17, 2020

Conversation

zarutian
Copy link
Contributor

To bring E() syntax/convience methods into alignment closer to
what is proposed/shown in https://github.com/tc39/proposal-eventual-send

@zarutian
Copy link
Contributor Author

Added only one test because, frankly I am stumped on how to check how test excercisement in the other cases.

@zarutian
Copy link
Contributor Author

pinging @Chris-Hibbert @erights @michaelfig and @warner per git-blame.

I am in no hurry for this PR to be reviewed if you all are super busy.

@michaelfig
Copy link
Member

I am in no hurry for this PR to be reviewed if you all are super busy.

Thanks for your patience!

@zarutian zarutian marked this pull request as ready for review October 13, 2020 19:24
@zarutian
Copy link
Contributor Author

Feel free to review this pull request anytime soon-ish.

michaelfig
michaelfig approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@michaelfig michaelfig merged commit 8dae74a into Agoric:master Oct 17, 2020
@zarutian
Copy link
Contributor Author

zarutian commented Oct 17, 2020 •
edited
Loading

I am still stumped on how to fully excercise this via tests as E.sendOnly() is a bit of a fire and forget functionality.

Note that this pr does not fully propagate the 'sendOnly'-ness to HandledPromise as those traps are still missing from HandledPromise at the time of this PR. But this is fine for now.

@zarutian zarutian deleted the patch-3 branch October 17, 2020 03:02
@michaelfig
Copy link
Member

That's fine. It's more important to get the API into place, so that consumers can start using it.

We'll clean up the rest when we move to Promise.delegate or similar.

@warner warner mentioned this pull request Mar 20, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zarutian @michaelfig