WIP Support fungible invites directly #1870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
requested review from
katelynsills,
warner and
kriskowal
and removed request for
warner,
kriskowal and
katelynsills
|
Sorry. Not ready for review. I accidentally asked for review because I thought I was on a different tab. |
erights
force-pushed
the
fungible-derivs
branch
from
4569681
to
e7c122c
Compare
erights
commented
Jan 20, 2021
Comment on lines
+87
to
+91
| if (leftI < leftLen) { | ||
| result.push(left[leftI]); | ||
| } else if (rightI < rightLen) { | ||
| result.push(right[rightI]); | ||
| } |
There was a problem hiding this comment.
I think these leftover processing loops should be while loops. Also the two in doSubtract below.
There was a problem hiding this comment.
Hmm. not sure. need closer examination than I'm about to give it.
|
This was described elsewhere as "objective" fungible versions of NFTs. If so, I think we don't want that as a feature. It looks like there is a lot of work in this PR to get the amount value elements sorted, though, so that is important to keep for future work. |
|
Closed in favor of #2642 |
|
Scavenged some into #3531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft. WIP. First step not obviously related --- not yet worth looking.