refactor(SwingSet): unify vat-worker filenames

[dckc]

fixes #2202

Makes me glad I invested in learning vs-code!

[dckc]

#2158 shows this is incomplete.

[dckc]

the filenames we're unifying also show up in a couple require.resolve calls in controller.js:

fbbd535

cc @warner

[warner]

Once #2217 lands, all workers should be getting exercised.

the filenames we're unifying also show up in a couple require.resolve calls in controller.js:

Yeah, controller.js is run inside the Start Compartment, so that's where we need to define the functions that create a new Node.js thread (new Worker(supercode)) and/or spawn a child process. It's also where we do the path algebra to locate the supervisor code that must be loaded into those new containers.

I'd suggest renaming those two functions (makeNodeWorker, startSubprocessWorker, startSubprocessWorkerXS) to match the pattern we're using in the other files, and of course update those filenames to match your file renames in src/kernel/vatManager/.

[dckc]

I rolled this into #2225