Reenable Docker builds and ag-setup-cosmos bootstrap #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
reviewed
Jan 29, 2021
dckc
reviewed
Jan 29, 2021
dckc
reviewed
Jan 29, 2021
dckc
approved these changes
Jan 29, 2021
michaelfig
force-pushed
the
mfig-docker-updates
branch
from
c6fbf26
to
807320f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
xsnapto be able to build as part ofcd packages/deployment && make docker-build.We remove the build from the Node.js
postinstallscript, since our Docker build relies on building only during thebuildscript.The other changes are needed to make the resulting Docker images viable. Can be tested with
NETWORK_NAME=mytestnet packages/deployment/docker/ag-setup-cosmos bootstrapand provisioning some Docker nodes (2 is fine).The patch to v0.41.0 proper is mentioned in cosmos/cosmos-sdk#8478 (comment)