store: refuse keys that are empty pass-by-copy objects #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
changed the title
warner
force-pushed
the
2018-store-no-empty-data-keys
branch
from
0d6dc4f
to
21ab960
Compare
|
@erights can you help me with the typescript problem? The PR fails lint and I don't know how to give the helper function a type that will satisfy it. |
|
You deleted helper.js but didn't push helpers.js |
warner
force-pushed
the
2018-store-no-empty-data-keys
branch
from
bc001b9
to
1288439
Compare
|
oops, fixed |
erights
approved these changes
Mar 10, 2021
|
ah, right, this needs to land on top of a cleanup in cosmic-swingset (#2567) which violates the rule we're imposing |
|
Btw, in Zenhub you declare that this PR is blocked on #2567 |
When #2018 changes the interpretation of `harden({})` to become pass-by-copy, any code which was previously using that to make a "handle" will break, because the things they send will be treated as pass-by-copy. To catch cases where this is happening, we forbid such keys from being used in store/weakstore. Clients should use `Far('interfacename')` to create handles, and these will be accepted by store/weakstore as keys.
warner
force-pushed
the
2018-store-no-empty-data-keys
branch
from
83286e3
to
c38a4dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To protect against surprises when we change
harden({})from pass-by-reference to pass-by-copy (#2018), @michaelfig and I figured that the simplest safety measure would be to havestore/weakstorerefuse such keys.This branch adds these checks, as well as a bunch of unit tests (it appeared to have none before).
I could use some help from a TypeScript guru, I can't seem to find a way to satisfy the signature of the helper function.