Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cosmic-swingset): more robustness around termination #2593

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented Mar 7, 2021

Closes #2581

Help ensure old ag-solos aren't left running if tests are interrupted.

@michaelfig michaelfig added the cosmic-swingset package: cosmic-swingset label Mar 7, 2021
@michaelfig michaelfig self-assigned this Mar 7, 2021
@michaelfig michaelfig requested review from dckc and erights March 7, 2021 19:47
@michaelfig michaelfig force-pushed the mfig-2581-cosmic-fixture-cleanup branch from 17b1679 to 466553b Compare March 7, 2021 21:16
@michaelfig michaelfig requested a review from erights March 8, 2021 00:40
Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelfig michaelfig merged commit ac15f4a into master Mar 8, 2021
@michaelfig michaelfig deleted the mfig-2581-cosmic-fixture-cleanup branch March 8, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn test failing because 127.0.0.1:7999 is already in use
2 participants