test and workaround for a reallocate issue in zoe #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue 3033 shows that reallocate fails unnecessarily if asked to reallocate to seats that had no previous allocation, even if the new allocations are empty. This works around that for the collectFees contract until a fix can be prepared.
Chris-Hibbert
added
bug
michaelfig
approved these changes
May 4, 2021
katelynsills
approved these changes
May 4, 2021
There was a problem hiding this comment.
Looks good to me, with the linting issue that @michaelfig mentioned fixed
Chris-Hibbert
added a commit
that referenced
this pull request
May 21, 2021
* chore: clean-up a work-around for a bug that's been fixed A bug was reported in #3032, #3034 worked around it, and #3033 fixed it. This removes the test and workaround. Removing the test seems to suppress the failure reported in #3079. That's good in reducing (possibly) spurious failures in CI, but may make it harder and less urgent to track down #3079. * test: reinstate the test, and update the comment The test demonstrates that the underlying bug stays fixed. * test: update test for to comport with the fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #3033 shows that reallocate fails unnecessarily if asked to
reallocate to seats that had no previous allocation, even if the new
allocations are empty.
This works around that for the collectFees contract until a fix can be prepared.