Warn for remotables not declared Remotable or Far #3504

erights · 2021-07-21T19:22:25Z

A step towards #3525

Deprecates implicit remotables. Makes more implicit remotables explicit.

erights · 2021-07-22T01:38:25Z

@michaelfig @warner I have two remaining failures:
https://github.com/Agoric/agoric-sdk/pull/3504/checks?check_run_id=3127742280
and
https://github.com/Agoric/agoric-sdk/pull/3504/checks?check_run_id=3127767756

which both seem to be about timeouts. But I suspect it is something else. Could you take a quick look and let me know what else comes to mind? Thanks.

warner · 2021-07-22T16:31:44Z

I don't know what's happening with those failures. I'm tempted to just push the "re-run all jobs" button and see if they go away. And/or if you rebase to current trunk and force-push, or add a commit, that will also trigger a rebuild.

michaelfig · 2021-07-22T19:40:30Z

@michaelfig @warner I have two remaining failures:
https://github.com/Agoric/agoric-sdk/pull/3504/checks?check_run_id=3127742280

https://github.com/Agoric/agoric-sdk/pull/3504/checks?check_run_id=3127742280#step:8:280 shows that the ag-solo is waiting on a notifier that never fires.

https://github.com/Agoric/agoric-sdk/pull/3504/checks?check_run_id=3127767756

https://github.com/Agoric/agoric-sdk/pull/3504/checks?check_run_id=3127767756#step:7:1 could be the same thing. Please run that test on your computer with cd packages/solo && NOISY=true yarn test -v

which both seem to be about timeouts. But I suspect it is something else. Could you take a quick look and let me know what else comes to mind? Thanks.

erights · 2021-07-23T06:36:40Z

Please run that test on your computer with cd packages/solo && NOISY=true yarn test -v

(1):solo(2018-markm-far-must-be-declared)$ NOISY=true yarn test -v
yarn run v1.22.5
$ ava -v

# connecting
.
'@agoric/install-ses' sniffed and found a 'LOCKDOWN_OPTIONS' environment variable

.
.
2021-07-22T22:17:00.695Z ag-solo: init: ag-solo initialized in /var/folders/g1/crzbwthn3n72s_8smhth9g_c0000gn/T//startsolo.83908
2021-07-22T22:17:00.695Z ag-solo: init: HTTP/WebSocket will listen on 127.0.0.1:7999
.
'@agoric/install-ses' sniffed and found a 'LOCKDOWN_OPTIONS' environment variable

.
.
'@agoric/install-ses' sniffed and found a 'LOCKDOWN_OPTIONS' environment variable

.
.
.
.
.
.
.
.
.
.
2021-07-22T22:17:13.682Z SwingSet: kernel: v5 online: xs-worker static name=bootstrap transcript entries replayed: 0
2021-07-22T22:17:13.695Z SwingSet: kernel: v7 online: local static name=comms transcript entries replayed: null
2021-07-22T22:17:13.851Z SwingSet: kernel: v2 online: xs-worker static name=http transcript entries replayed: 0
2021-07-22T22:17:13.998Z SwingSet: kernel: v3 online: xs-worker static name=network transcript entries replayed: 0
2021-07-22T22:17:14.155Z SwingSet: kernel: v1 online: xs-worker static name=spawner transcript entries replayed: 0
.
2021-07-22T22:17:14.290Z SwingSet: kernel: v9 online: xs-worker static name=timer transcript entries replayed: 0
2021-07-22T22:17:14.409Z SwingSet: kernel: v4 online: xs-worker static name=uploads transcript entries replayed: 0
2021-07-22T22:17:14.536Z SwingSet: kernel: v6 online: xs-worker static name=vatAdmin transcript entries replayed: 0
2021-07-22T22:17:14.664Z SwingSet: kernel: v8 online: xs-worker static name=vattp transcript entries replayed: 0
2021-07-22T22:17:15.175Z start: adding HTTP/WS listener on 127.0.0.1:7999
2021-07-22T22:17:15.178Z web: Serving static files from /private/var/folders/g1/crzbwthn3n72s_8smhth9g_c0000gn/T/startsolo.83908/html
2021-07-22T22:17:15.180Z start: adding follower/sender for fake chain mySimGCI
2021-07-22T22:17:15.182Z launch-chain: Launching SwingSet kernel
2021-07-22T22:17:15.202Z web: Listening on 127.0.0.1:7999
.
2021-07-22T22:17:15.212Z web: 127.0.0.1:64774[1]: new WebSocket /private/captp?accessToken=8nxqnCoDMMxOHcbmG6yainDt786vw-23LjCOPMv3yrXQs9MxG_Oj54U1PdmhMZ23
o
o
2021-07-22T22:17:24.716Z SwingSet: kernel: v1 online: xs-worker static name=bank transcript entries replayed: 0
2021-07-22T22:17:24.880Z SwingSet: kernel: v2 online: xs-worker static name=board transcript entries replayed: 0
2021-07-22T22:17:25.470Z SwingSet: kernel: v11 online: xs-worker static name=bootstrap transcript entries replayed: 0
2021-07-22T22:17:25.485Z SwingSet: kernel: v13 online: local static name=comms transcript entries replayed: null
2021-07-22T22:17:25.625Z SwingSet: kernel: v3 online: xs-worker static name=distributeFees transcript entries replayed: 0
2021-07-22T22:17:25.796Z SwingSet: kernel: v4 online: xs-worker static name=ibc transcript entries replayed: 0
2021-07-22T22:17:25.974Z SwingSet: kernel: v5 online: xs-worker static name=mints transcript entries replayed: 0
2021-07-22T22:17:26.127Z SwingSet: kernel: v6 online: xs-worker static name=network transcript entries replayed: 0
2021-07-22T22:17:26.345Z SwingSet: kernel: v7 online: xs-worker static name=priceAuthority transcript entries replayed: 0
2021-07-22T22:17:26.481Z SwingSet: kernel: v8 online: xs-worker static name=provisioning transcript entries replayed: 0
2021-07-22T22:17:26.616Z SwingSet: kernel: v9 online: xs-worker static name=sharing transcript entries replayed: 0
2021-07-22T22:17:26.759Z SwingSet: kernel: v15 online: xs-worker static name=timer transcript entries replayed: 0
2021-07-22T22:17:26.884Z SwingSet: kernel: v12 online: xs-worker static name=vatAdmin transcript entries replayed: 0
2021-07-22T22:17:27.020Z SwingSet: kernel: v14 online: xs-worker static name=vattp transcript entries replayed: 0
2021-07-22T22:17:27.349Z SwingSet: kernel: v10 online: xs-worker static name=zoe transcript entries replayed: 0
2021-07-22T22:17:28.272Z SwingSet: kernel: v16 online: xs-worker  transcript entries replayed: 0
2021-07-22T22:17:28.535Z SwingSet: kernel: v17 online: xs-worker  transcript entries replayed: 0
2021-07-22T22:17:29.604Z SwingSet: kernel: v18 online: xs-worker  transcript entries replayed: 0
Logging sent error stack (Error#1)
Error#1: Bank doesn't implement fee collectors
Error: Bank doesn't implement fee collectors
 at apply ()
 at Error ()
 at getFeeCollectorDepositFacet ()
 at ()
 at win ()
 at ()

Error#1 ERROR_NOTE: Thrown from: (Error#2) : 2 . 0
Error#1 ERROR_NOTE: Sent as error:liveSlots:v1#70001
Error#2: Event: 1.1
Error: Event: 1.1
 at construct ()
 at Error ()
 at trackTurns ()
 at handle ()
 at deliver ()
 at dispatchToUserspace ()
 at ()

2021-07-22T22:17:30.352Z SwingSet: vat: v11: Cannot create fee collector [Error: Bank doesn't implement fee collectors]
2021-07-22T22:17:31.708Z SwingSet: kernel: v19 online: xs-worker  transcript entries replayed: 0
2021-07-22T22:17:31.979Z SwingSet: kernel: v20 online: xs-worker  transcript entries replayed: 0
2021-07-22T22:17:32.273Z SwingSet: kernel: v21 online: xs-worker  transcript entries replayed: 0
2021-07-22T22:17:32.542Z SwingSet: kernel: v22 online: xs-worker  transcript entries replayed: 0
2021-07-22T22:17:32.804Z SwingSet: kernel: v23 online: xs-worker  transcript entries replayed: 0
2021-07-22T22:17:39.415Z SwingSet: vat: v16: ----- ST.5  2 depositValue {
  Central: { brand: '[Alleged: RUN brand]', value: '[0n]' },
  Liquidity: {
    brand: '[Alleged: BLDLiquidity brand]',
    value: '[558000000000000n]'
  },
  Secondary: { brand: '[Alleged: BLD brand]', value: '[0n]' }
}
2021-07-22T22:17:39.463Z SwingSet: vat: v16: ----- ST.5  3 depositValue {
  Central: { brand: '[Alleged: RUN brand]', value: '[0n]' },
  Liquidity: {
    brand: '[Alleged: ATOMLiquidity brand]',
    value: '[18610000000000n]'
  },
  Secondary: { brand: '[Alleged: ATOM brand]', value: '[0n]' }
}
2021-07-22T22:17:39.500Z SwingSet: vat: v16: ----- ST.5  4 depositValue {
  Central: { brand: '[Alleged: RUN brand]', value: '[0n]' },
  Liquidity: {
    brand: '[Alleged: ETHLiquidity brand]',
    value: '[1914860000000000n]'
  },
  Secondary: { brand: '[Alleged: ETH brand]', value: '[0n]' }
}
2021-07-22T22:17:39.539Z SwingSet: vat: v16: ----- ST.5  5 depositValue {
  Central: { brand: '[Alleged: RUN brand]', value: '[0n]' },
  Liquidity: {
    brand: '[Alleged: LINKLiquidity brand]',
    value: '[27900000000000n]'
  },
  Secondary: { brand: '[Alleged: LINK brand]', value: '[0n]' }
}
2021-07-22T22:17:39.576Z SwingSet: vat: v16: ----- ST.5  6 depositValue {
  Central: { brand: '[Alleged: RUN brand]', value: '[0n]' },
  Liquidity: {
    brand: '[Alleged: USDCLiquidity brand]',
    value: '[10000000000000n]'
  },
  Secondary: { brand: '[Alleged: USDC brand]', value: '[0n]' }
}
2021-07-22T22:17:40.342Z SwingSet: vat: v11: Making fake price authority for RUN-moola
2021-07-22T22:17:40.343Z SwingSet: vat: v11: Making fake price authority for moola-RUN
2021-07-22T22:17:40.353Z SwingSet: vat: v11: Making fake price authority for RUN-simolean
2021-07-22T22:17:40.354Z SwingSet: vat: v11: Making fake price authority for simolean-RUN
2021-07-22T22:17:40.736Z start: swingset running
'@agoric/install-ses' sniffed and found a 'LOCKDOWN_OPTIONS' environment variable

Open CapTP connection to ws://127.0.0.1:7999/private/captp...
2021-07-22T22:17:42.289Z web: 127.0.0.1:64779[2]: new WebSocket /private/captp?accessToken=8nxqnCoDMMxOHcbmG6yainDt786vw-23LjCOPMv3yrXQs9MxG_Oj54U1PdmhMZ23
o
o
o
o
[... many many more]
o
o
o
o
o
^C  
  ✖ Exiting due to SIGINT

  6 tests were pending in test/test-home.js

  ◌ home.board
  ◌ home.wallet - receive zoe invite
  ◌ home.wallet - central issuer setup
  ◌ home.localTimerService makeNotifier
  ◌ home.localTimerService createRepeater
  ◌ home.localTimerService makeRepeater

  ─

solo(2018-markm-far-must-be-declared)$

michaelfig · 2021-07-23T15:31:06Z

(1):solo(2018-markm-far-must-be-declared)$ NOISY=true yarn test -v

All those os are the sim-chain reporting that the CapTP connection is ready, but somehow the messages from the solo are being silently dropped (or at least, not resulting in fulfilment of an E(x) promise). Probably the same "notifier never fires" problem.

michaelfig

Looks good!

packages/marshal/src/passStyleOf.js

erights added the hygiene Tidying up around the house label Jul 21, 2021

erights self-assigned this Jul 21, 2021

erights requested review from warner and michaelfig July 21, 2021 19:24

erights marked this pull request as draft July 21, 2021 20:24

erights marked this pull request as ready for review July 22, 2021 01:35

erights force-pushed the 2018-markm-far-must-be-declared branch from 89f7364 to 673bea9 Compare July 25, 2021 06:50

michaelfig approved these changes Jul 25, 2021

View reviewed changes

packages/marshal/src/passStyleOf.js Outdated Show resolved Hide resolved

packages/marshal/src/passStyleOf.js Outdated Show resolved Hide resolved

erights added 7 commits July 25, 2021 11:56

fix: more missing Fars

03baab4

fix: Require remotables to be declared

a2cc494

fix: improve diagnostic. fix pegasus

a5bd358

fix: downgraded to warning

eae4f7f

fix: import order

4bf0d97

fix: review comments

d9e9896

fix: more missing fars

ff7c767

erights force-pushed the 2018-markm-far-must-be-declared branch from a110d22 to ff7c767 Compare July 25, 2021 18:57

erights mentioned this pull request Jul 25, 2021

Enable enforcement that far must be declared #3525

Merged

erights changed the title ~~Require remotables to be declared~~ Warn for remotables that are not declared Remotable or Far Jul 25, 2021

erights changed the title ~~Warn for remotables that are not declared Remotable or Far~~ Warn for remotables not declared Remotable or Far Jul 25, 2021

erights enabled auto-merge (squash) July 25, 2021 19:21

erights merged commit e454898 into master Jul 25, 2021

erights deleted the 2018-markm-far-must-be-declared branch July 25, 2021 19:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Warn for remotables not declared Remotable or Far #3504

Warn for remotables not declared Remotable or Far #3504

erights commented Jul 21, 2021 •

edited

Loading

erights commented Jul 22, 2021

warner commented Jul 22, 2021

michaelfig commented Jul 22, 2021

erights commented Jul 23, 2021 •

edited

Loading

michaelfig commented Jul 23, 2021

michaelfig left a comment

Warn for remotables not declared Remotable or Far #3504

Warn for remotables not declared Remotable or Far #3504

Conversation

erights commented Jul 21, 2021 • edited Loading

erights commented Jul 22, 2021

warner commented Jul 22, 2021

michaelfig commented Jul 22, 2021

erights commented Jul 23, 2021 • edited Loading

michaelfig commented Jul 23, 2021

michaelfig left a comment

Choose a reason for hiding this comment

erights commented Jul 21, 2021 •

edited

Loading

erights commented Jul 23, 2021 •

edited

Loading