-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmos-level Vbank governance #3665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3424 |
JimLarson
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with suggested cleanups.
The new Cosmos-SDK 0.43.0 adds an `-ojson` flag to the `tx` subcommands, so we can both specify it when we need and don't have to force users to look at JSON when the default is clearer.
543b77a
to
546b530
Compare
This was referenced Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to get our toes wet with Cosmos-level governance. The intention is to allow
x/swingset
to govern cosmic-swingset scheduler parameters (like number of computrons per block).To fix some brokenness caused by RESM->NESM, we convert
calc-gci.js
andadd-gci-ingress.js
to NESM, and movecheck-validator.js
to have a.cjs
extension.It also upgrades to the latest agoric-labs/cosmos-sdk (v0.43.0-alpha.agoric).
And just for good measure, we implement
ag-cosmos-helper query vbank params
.