Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(swingset-runner): Convert RESM to NESM #3671

Merged
merged 3 commits into from
Aug 14, 2021
Merged

Conversation

kriskowal
Copy link
Member

Refs #527

This change removes the ESM emulation layer in favor of standing directly on Node.js’s ESM implementation. A second commit adds a coverage script (with no enforced thresholds).

@kriskowal kriskowal requested a review from FUDCo August 12, 2021 21:56
@kriskowal kriskowal changed the base branch from master to 527-agoric August 12, 2021 21:56
@kriskowal kriskowal marked this pull request as draft August 12, 2021 22:03
@kriskowal
Copy link
Member Author

Lint won’t pass until I cut a new release of @endo/eslint-config. The demo directory entrains dependencies but should only entrain devDependencies.

Copy link
Contributor

@FUDCo FUDCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's always great when somebody else does the remarkably tedious parts.

@kriskowal
Copy link
Member Author

It's always great when somebody else does the remarkably tedious parts.

It’s a living, but in fairness, git grep __dirname | cut -d: -f1 | xargs -o vim did most of the work.

Base automatically changed from 527-agoric to master August 13, 2021 00:35
@kriskowal kriskowal force-pushed the 527-swingset-runner branch from 0addcc6 to f010f36 Compare August 13, 2021 21:07
@kriskowal kriskowal changed the base branch from master to 527-sync-endo August 13, 2021 21:07
@kriskowal kriskowal marked this pull request as ready for review August 13, 2021 21:24
@kriskowal kriskowal force-pushed the 527-swingset-runner branch from f010f36 to 26a27e2 Compare August 13, 2021 23:58
Base automatically changed from 527-sync-endo to master August 14, 2021 01:57
@kriskowal kriskowal merged commit a861c78 into master Aug 14, 2021
@kriskowal kriskowal deleted the 527-swingset-runner branch August 14, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants