Added Chainlink aggregator with tests #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
reviewed
Aug 13, 2021
packages/zoe/tools/types.js
Outdated
| @@ -14,7 +14,7 @@ | |||
| * @typedef {Object} PriceDescription A description of a single quote | |||
| * @property {Amount} amountIn The amount supplied to a trade | |||
| * @property {Amount} amountOut The quoted result of trading `amountIn` | |||
| * @property {TimerService} timer The service that gave the `timestamp` | |||
| * @property {ERef<TimerService>} timer The service that gave the `timestamp` | |||
There was a problem hiding this comment.
I suggest reverting this. The PriceDescription needs to be comparable, and that means the timer should be awaited before putting it in the description.
michaelfig
reviewed
Aug 13, 2021
| AmountMath.coerce(amountOut, brandOut); | ||
| if (theirTimestamp !== undefined) { | ||
| return authenticateQuote([ | ||
| { amountIn, amountOut, timer, timestamp: theirTimestamp }, |
There was a problem hiding this comment.
This is how we use the non-ERef form of the timer as an identity:
Suggested change
| { amountIn, amountOut, timer, timestamp: theirTimestamp }, | |
| { amountIn, amountOut, timer: timerPresence, timestamp: theirTimestamp }, |
michaelfig
reviewed
Aug 13, 2021
michaelfig
reviewed
Aug 13, 2021
| return E(timer) | ||
| .getCurrentTimestamp() | ||
| .then(now => | ||
| authenticateQuote([{ amountIn, amountOut, timer, timestamp: now }]), |
There was a problem hiding this comment.
Please do the same with timer: timerPresence here.
yashpatel5400
force-pushed
the
master
branch
3 times, most recently
from
f286e77 to
99fe4a4
Compare
|
Addressed comments |
This was referenced Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for changes requested in https://gitcoin.co/issue/Agoric/agoric-sdk/3200/100026006