Suggestion for #3448: subscribe to questions, rather than notify #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ContractGovernor is an ElectionManager that knows its Registrar, and starts up and manages one contract. The managed contract returns a facet that describes the managed parameters to the governor. The ContractGovernor returns a facet that allows the creation of new Ballot questions to ask the electorate to approve changing the values of those parameters. There's a README.md that gives on overview of the interdependent APIs. The swingsetTest exercise the ContractGovernor over a trivial governedContract that shows how a contract can configure its parameters, and the methods that have to be available in order for everything to be found and verified. The tests include a verification step that cross-checks the Registrar, ElectionManager (i.e. ContractGovernor in this case), and Ballots to see that they are consistent. The API of Ballot and others is changed to bundle the details of a question into BallotSpec. This affects some of the unit tests.
Rename HALF to MAJORITY, and NONE to NO_QUORUM break up long lines in types.js Add bullet points to break up paragraph in choiceMethod use typescript sub-type declarations fix QuestionTerms patch around a ts confusion.
fixed typos, etc. added detail in README on Future Enhancements Integrated with fees for zoe execution integrated with ENDO changes to import formatting Added checking of Installations now that Zoe has getInstallationForInstance
rename ballot validation to looksLike improve checking for ballotDetails
|
Subscription and Notifier were co-designed so that it would be easy to switch from one to the other, as demonstrated by this PR. |
Chris-Hibbert
force-pushed
the
contractGovernanceMgr-3185
branch
2 times, most recently
from
577ad0d to
0117ede
Compare
|
These changes have been merged into 3448. I'll add a |
Chris-Hibbert
force-pushed
the
contractGovernanceMgr-3185
branch
4 times, most recently
from
8ebabda to
20e1ec6
Compare
Chris-Hibbert
force-pushed
the
contractGovernanceMgr-3185
branch
2 times, most recently
from
afd01b5 to
e3fa924
Compare
|
Obsolete. Suggestion already applied. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion for #3448
The notifier notifies of each individual question. The one consumer (a test) assumes it gets notified about each question. The test passes only because this accidentally happens. It is outside the notifier spec, which may not notify of earlier questions if there are later questions to notify of instead. But a later question does not make an earlier question irrelevant, so this was never a job for notifiers.