docs(amm): type docs, test optimization #3920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses Ratios pervasively in calculating prices and fees Uses virtual pools to calculate prices and do swaps for two hop trades
speeds up tests from around 5 sec to around 1 sec
in all but the one conflict between docs and code, the latent types were straightforward
Chris-Hibbert
force-pushed
the
constantProductAMM
branch
from
4d836a5 to
3c078fe
Compare
|
@dckc, can this be closed? |
|
yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helped me review the code. If you're inclined to merge it into your branch, feel free, @Chris-Hibbert .
Otherwise, I may submit it later.