-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade to Cosmos SDK v0.44.0-alpha.agoric.1 #4131
Conversation
bad3760
to
4310049
Compare
4a51471
to
aee9548
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go stuff looks good. You might want another reviewer to cover the JS files.
aee9548
to
b1c6836
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one suggestion and one question; neither is critical
decohered = Error( | ||
`Block ${action.blockHeight} begun with leftover uncommitted actions: ${leftover}`, | ||
); | ||
throw decohered; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this crash before the bad state gets committed or after? I think either design is acceptable, but I'd like to know which we're aiming at. Before is better, but it's still bad...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simulation happens between blocks. So, it crashes before since no simulated transactions have yet been sent up to SwingSet before this point.
b1c6836
to
c1aad7d
Compare
c1aad7d
to
32f879b
Compare
Description
Upgrades to new Cosmos SDK+Agoric patches.
Also, in the ongoing battle against nondeterminism, crash cosmic-swingset if there are actions left over from a previous block. That should never happen, and was an indication a while ago that we were accidentally sending simulated transactions to SwingSet.
Security Considerations
Documentation Considerations
Testing Considerations