chore: simplify prettierignore #4480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
ta/rm-prettier-exception
branch
from
6973e2d
to
270167c
Compare
What is the plan to keep this file in sync with upstream? Reformatting usually creates headaches. |
I assume that when someone wants to pull changes from the original source they would pretty it first so they could get a useful diff. |
mhofman
reviewed
Feb 7, 2022
Comment on lines
-18
to
-20
| # subrepos | ||
| /packages/xsnap/moddable | ||
| /packages/xsnap/xsnap-native |
There was a problem hiding this comment.
How do we prevent prettier from reaching into subrepos without this?
There was a problem hiding this comment.
Indeed. This was an error introduced when I testing whether nested ignore files worked. (They don't) I'll restore. Thankfully the linter complained too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing special cases in prettierignore, came up in #4364 (comment)
Also removed the nested
.prettierignorefiles because they're not read during the root command prettier/prettier#4081Security Considerations
--
Documentation Considerations
Reduces need for documenation
Testing Considerations
--