autoformat jsdoc of some packages #4906

turadg · 2022-03-23T23:47:10Z

Description

Enable #4903 just for these packages,

ertp
inter-protocol
vats

There are more formatting options we could consider eventually. This adopts the minimum set to reduce the friction to getting the main value: auto-formatting type annotations.

Security Considerations

--

Documentation Considerations

Until #4900 is complete we'll have to selectively enable paths with the glob.

Testing Considerations

Verify that re-reunning yarn format is stable and only affects opt-in packages.
verify that yarn prettier in a opt-in path is formatted and others aren't
verify that formatOnSave in a opt-in path is formatted and others aren't

packages/run-protocol/src/vaultFactory/vault.js

Chris-Hibbert

just getting started. Here are some reactions.

On the whole, I like the changes. I don't understand when it switches commas to semicolons in lists, though.

Chris-Hibbert · 2022-03-24T16:08:27Z

packages/run-protocol/src/vaultFactory/types.js

- * pool, taken from the `fromSeat`. Then reallocate over all the seat
- * arguments and the rewardPoolSeat.
- *
+ * @callback ReallocateWithFee Transfer the indicated amount to the


This change makes it harder to distinguish the comment from the name when reading the source. Is there punctuation that can be inserted (' - ' for instance) that makes it more visible?

Agree for code reviews. In an IDE it's still quite readable:

I don't see an option to change this. I could file one but I'm not sure what to ask for… that an exception be made for callbacks?

I think this would be most in line with JSDoc and our other function comments:

/** * Transfer the indicated amount to the vaultFactory's reward pool, taken from * the `fromSeat`. Then reallocate over all the seat arguments and the rewardPoolSeat. * * @callback ReallocateWithFee * @param {Amount} amount * @param {ZCFSeat} fromSeat * @param {ZCFSeat} [otherSeat] * @returns {void} */

which renders on hover as,

It's nice that VSCode does that, but WebStorm doesn't color code the types.js file.

As a matter of fact, I now see that at the call site for reallocateWithFee, WebStorm tells me that the type is ReallocateWithFee, and doesn't give any help on the parameters. (This is at line 589 in vault.js. WS shows no parameter help for manager.reallocateWithFee(, but the adjacent transfer shows a popup of fromSeat, toSeat, fromLoses, toGains, key.) I've been noticing missing parameter help recently, but didn't notice that it was simultaneously present on other calls.

It's nice that VSCode does that, but WebStorm doesn't color code the types.js file.

That was just the style I was using. It did distinguish and allowed me to make them more distinct.

at the call site for reallocateWithFee, WebStorm tells me that the type is ReallocateWithFee, and doesn't give any help on the parameters.

After some experimentation with @turadg, we found that @callback didn't pass the parameters through, but a direct declaration of the arguments did. I will experiment so we don't have to describe all the parameters at each declaration. (The particular example I was experimenting with was passed through several layers of API to get to where it was being used.)

Chris-Hibbert · 2022-03-24T16:11:14Z

packages/run-protocol/src/vaultFactory/vault.js

+ *     ACTIVE       - vault is in use and can be changed
+ *     LIQUIDATING  - vault is being liquidated by the vault manager, and cannot be changed by the user


Is it the presence of the dashes here that told it not to reflow? Did it notice that the dashes lined up, or did it accidentally preserve that?

The dashes were lined up before. The indentation told it not to reformat. Though there is a bug to watch out for hosseinmd/prettier-plugin-jsdoc#155

Chris-Hibbert · 2022-03-24T17:39:32Z

packages/run-protocol/src/vaultFactory/types.js

+ * @property {Ratio} interestRate Annual interest rate charged on loans
+ * @property {Ratio} loanFee The fee (in BasisPoints) charged when opening or


Dropping the dashes leads to worse readability in the source. Are the dashes not understood as separators by the jsdoc interpreter?

I withdraw this. The IDE does a decent job of distinguishing defined names from commentary.

Chris-Hibbert · 2022-03-24T17:44:58Z

packages/run-protocol/src/vpool-xyk-amm/addLiquidity.js

+ *       so targetK equals startK because we square targetY
+ *     targetK = targetX * targetY = desiredRatio * (startK / desiredRatio)
+ *
+ * Since startK/endK is less than one, and we have to worry about early loss of


Repeated line?

oops yeah, bad copy paste in the manual fix commit

packages/run-protocol/src/vpool-xyk-amm/constantProduct/calcFees.js

packages/run-protocol/src/vpool-xyk-amm/constantProduct/core.js

Chris-Hibbert · 2022-03-24T17:49:36Z

packages/run-protocol/src/vpool-xyk-amm/constantProduct/invariants.js

@@ -6,12 +6,12 @@ import { AmountMath } from '@agoric/ertp';
 import { natSafeMath } from '@agoric/zoe/src/contractSupport/index.js';

 /**
- * xy <= (x + deltaX)(y - deltaY)
+ * `Xy <= (x + deltaX)(y - deltaY)`


changing from lower case is a mistake.

Interesting, it both added backticks and changed the case. I don't think it should have done either.

Human error: I added the backticks so it wouldn't change the case, but I forgot to undo its case change. Fixed.

packages/run-protocol/src/vpool-xyk-amm/constantProduct/invariants.js

Chris-Hibbert · 2022-03-24T17:53:13Z

packages/run-protocol/src/vpool-xyk-amm/multipoolMarketMaker.js

@@ -95,32 +93,30 @@ const { quote: q, details: X } = assert;
 * The creatorFacet has one method (makeCollectFeesInvitation, which returns
 * collected fees to the creator). `handleParamGovernance()` adds internal
 * methods used by the contractGovernor. The contractGovernor then has access to
- * those internal methods, and reveals the original AMM creatorFacet to its own
- * creator.
+ * those internal methods, and reveals the original AMM creatorFacet to its own creator.


The line breaking algorithm is surprising. If the last line can be this long, why didn't it re-flow the previous lines?

* The creatorFacet has one method (makeCollectFeesInvitation, which returns collected * fees to the creator). `handleParamGovernance()` adds internal methods used by the * contractGovernor. The contractGovernor then has access to those internal methods, and * reveals the original AMM creatorFacet to its own creator.

I've seen other examples above where the last line is visibly longer than those that precede it.

It's a benefit to not have to think about line breaking, but this is a bizarre approach.

My guess is it has a width tolerance factor to prevent runts (had to look that up).

I'm happy that code formatters mean I don't have to think about line wrapping. =)

Chris-Hibbert · 2022-03-24T17:56:06Z

packages/run-protocol/src/vpool-xyk-amm/singlePool.js

+ * @param {() => bigint} getProtocolFeeBP - Retrieve governed protocol fee value
+ * @param {() => bigint} getPoolFeeBP - Retrieve governed pool fee value


See! The dashes can be kept.

Yes, it doesn't do any dash removal. That was me manually to be consistent with the places we don't use dashes and because the new capitalization provides a distinguishing feature when syntax highlighting isn't available.

turadg · 2022-03-24T18:43:51Z

packages/run-protocol/src/vaultFactory/vault.js

@@ -23,7 +23,7 @@ const { details: X, quote: q } = assert;
 const trace = makeTracer('IV');

 /**
- * @file This has most of the logic for a Vault, to borrow RUN against collateral.
+ * @file This Has most of the logic for a Vault, to borrow RUN against collateral.


I don't think this @file take a keyword before the prose

this was fixed 8 hours ago before my comment! hosseinmd/prettier-plugin-jsdoc#143 (comment)

018d239

turadg · 2022-03-24T23:49:49Z

On the whole, I like the changes.

Me too. I'm going to mark this ready for review.

UPDATE: I noticed in VS Code that when the plugin is installed by Yarn that my saveOnFormat is formatting everywhere because it's not getting the --no-plugin-search option in package.json. I think this is a blocker. I'll try to solve before marking for review again.

I don't understand when it switches commas to semicolons in lists, though.

That's for TypeScript fragments within a @typedef, which is more in line with TypeScript conventions. It's also what Prettier would do for plain .ts.

erights

LGTM, thanks!

packages/run-protocol/src/interest.js

erights · 2022-03-25T00:01:49Z

packages/run-protocol/src/vaultFactory/types.js

+ * Transfer the indicated amount to the vaultFactory's reward pool, taken from
+ * the `fromSeat`. Then reallocate over all the seat arguments and the rewardPoolSeat.
 *
+ * @callback ReallocateWithFee


Did it swap the declaration and prose automatically, or did manually intervene? Do they both mean the same thing in jsdoc?

This was manual. When the prose is below a tag it is treated as part of the tag and put onto the same line. I.e. @callback ReallocateWithFee Transfer the indicated amount…. IDE renders it the same either way way.

I thought of filing that as a bug but on second thought I figured it was a reasonable thing to keep tags grouped together at the bottom like in other functions. That's the ordering in JSDoc examples of callback.

Thinking through it more, it's better for the tool not to move @typedef or @callback descriptions. I've filed hosseinmd/prettier-plugin-jsdoc#156

erights · 2022-03-25T00:02:54Z

packages/run-protocol/src/vaultFactory/vault.js

- * - the absence of one of these implies the opposite, so `newDebt` is the
- *   future value fo `debt`, as computed based on values after any `await`
+ *   A note on naming convention:
+ *


Did it insert a blank line here? Why?

Yes. I think because list items followed.

erights · 2022-03-25T00:04:06Z

packages/run-protocol/src/vaultFactory/vault.js

+   * @returns {Amount<'nat'>} As if the vault was open at the launch of this
+   *   manager, before any interest accrued
   * @see getActualDebAmount


Swapped automatically?

Yes, it puts @see at the end

erights · 2022-03-25T00:05:42Z

packages/run-protocol/src/vpool-xyk-amm/constantProduct/calcFees.js

@@ -32,7 +32,7 @@ const amountGT = (left, right) =>
 * Apply the feeRatio to the amount that has a matching brand. This used to
 * calculate fees in the single pool case.
 *
- * @param {{ amountIn: Amount, amountOut: Amount}} amounts - a record with two
+ * @param {{ amountIn: Amount; amountOut: Amount }} amounts - A record with two


Why didn't it remove this hyphen?

It doesn't do anything with hyphens. I removed some manually for consistency in this package. Rationale being that the capitalization is enough to set it apart from the param name.

erights · 2022-03-25T00:07:08Z

packages/run-protocol/src/vpool-xyk-amm/constantProduct/core.js

@@ -80,13 +80,12 @@ export const calcDeltaYSellingX = (x, y, deltaX) => {
 * pool for that asset. swapInReduced calls this with the calculated amountOut
 * to find out if less than the offeredAmountIn would be sufficient.
 *
- * deltaX = (deltaYOverY/(1 - deltaYOverY))*x
- * Equivalently: (deltaY / (Y - deltaY )) * x
+ * DeltaX = (deltaYOverY/(1 deltaYOverY))*x Equivalently: (deltaY / (Y - deltaY )) * x


This lost linebreak expressed intended meaning. Needs to be restored somehow.

erights · 2022-03-25T00:08:40Z

packages/run-protocol/src/vpool-xyk-amm/constantProduct/invariants.js

@@ -6,12 +6,12 @@ import { AmountMath } from '@agoric/ertp';
 import { natSafeMath } from '@agoric/zoe/src/contractSupport/index.js';

 /**
- * xy <= (x + deltaX)(y - deltaY)
+ * `xy <= (x + deltaX)(y - deltaY)`


Ok, this was manual. But still curious: Did you do the manual intervention on the input or the output?

If the question is whether the formatter would modify it without backticks, yes it would capitalize because jsdocCapitalizeDescription is left at its default of true.

Alternately I can disable that and we can leave capitalization alone. IMO it's better to enable it to force us to notice what is interpreted as prose, because any rendering of the docstring will render it that way.

Though I can also accept that even if we do agree to that, as a matter of migration we tackle that in a separate stage so that just getting all onto this tool happens faster.

erights · 2022-03-25T00:10:53Z

packages/run-protocol/src/vpool-xyk-amm/multipoolMarketMaker.js

@@ -95,32 +93,30 @@ const { quote: q, details: X } = assert;
 * The creatorFacet has one method (makeCollectFeesInvitation, which returns
 * collected fees to the creator). `handleParamGovernance()` adds internal
 * methods used by the contractGovernor. The contractGovernor then has access to
- * those internal methods, and reveals the original AMM creatorFacet to its own
- * creator.
+ * those internal methods, and reveals the original AMM creatorFacet to its own creator.


turadg · 2022-03-26T01:31:09Z

This is blocked on getting the selective opt-in to work. Reported in https://github.com/hosseinmd/prettier-plugin-jsdoc/issues/157

turadg · 2022-03-30T19:08:57Z

packages/run-protocol/src/runStake/runStake.js

 * }} RunStakePublic
+ *   To take out a loan, get an `AttestationMaker` for your address from the


@dckc the formatter reads the paragraph following a typedef as being about that typedef and so indents it.

I think this will be fixed by https://github.com/hosseinmd/prettier-plugin-jsdoc/issues/156

kriskowal

Good idea as far as I’m concerned.

kriskowal · 2023-06-16T18:44:10Z

packages/run-protocol/test/reserve/setup.js

- *     reserve: ReserveKit,
- *     invitationAmount: Amount,
- *     space: any,
+ *   zoe: ZoeService;


semicolons. That’s interesting. Is that consistent with TS?

I believe TSC prefers semicolons

dckc

The style is generally nicer.

My eyes glazed over about half way thru, so I can't vouch for all the details.

I have a vague unease about changing our bundles for non-functional reasons, but I suppose I can go with "the future is longer than the past".

packages/inter-protocol/scripts/manual-price-feed.js

dckc · 2023-07-18T04:21:59Z

packages/inter-protocol/scripts/deploy-contracts.js

-  /** @type {CopyMap<string, {installation: Installation, boardId: string, path?: string}>} */
+  /**
+   * @type {CopyMap<


I think this file is dead code. I guess it doesn't hurt to tweak it, though...

dckc · 2023-07-18T04:23:56Z

packages/inter-protocol/src/auction/auctionBook.js

+ *     | {
+ *         offerPrice: Ratio;
+ *       }
+ *     | {
+ *         offerBidScaling: Ratio;
+ *       }


if we write each of these as 1 line instead of 3, will the tool leave them alone?

dckc · 2023-07-18T04:24:58Z

packages/inter-protocol/src/auction/auctioneer.js

- * Return a set of transfers for atomicRearrange() that distribute
- * `unsoldCollateral` and `proceeds` proportionally to each seat's deposited
- * amount. Any uneven split should be allocated to the reserve.
+ * collected from the auction participants is `proceeds`. Return a set of


does @returns make sense here?

dckc · 2023-07-18T04:25:19Z

packages/inter-protocol/src/auction/auctioneer.js

- * Return a set of transfers for atomicRearrange() that distribute
- * `unsoldCollateral` and `proceeds` proportionally to each seat's deposited
- * amount. Any uneven split should be allocated to the reserve.
+ * collected from the auction participants is `proceeds`. Return a set of


again: @returns?

dckc · 2023-07-18T04:26:13Z

packages/inter-protocol/src/auction/offerBook.js

+ *     | { bidScaling: Pattern; price: undefined }
+ *     | { bidScaling: undefined; price: Ratio }


this answers my earlier question: yes, the tool leaves it alone if we write these as 1 line each instead of 3

dckc · 2023-07-18T04:26:50Z

packages/inter-protocol/src/auction/offerBook.js

@@ -51,7 +54,6 @@ export const prepareScaledBidBook = baggage =>
    'scaledBidBook',
    undefined,
    /**
-     *


Removing that blank line when it's not used is nice.

dckc · 2023-07-18T04:37:55Z

packages/inter-protocol/test/reserve/test-reserve.js

- * @param {*} faucetInstallation
- * @param {*} stableInitialLiquidity
+ * @param {any} faucetInstallation
+ * @param {any} stableInitialLiquidity


rewriting * as any... interesting.

packages/vats/test/bootstrapTests/test-vaults-upgrade.js

Chris-Hibbert · 2023-07-18T16:27:32Z

packages/inter-protocol/src/auction/auctionBook.js

+ * @property {Ratio | null} startPrice identifies the priceAuthority and price
+ * @property {Ratio | null} currentPriceLevel the price at the current auction
+ *   tier
+ * @property {Amount<'nat'> | null} startProceedsGoal The proceeds the sellers
+ *   were targeting to raise
+ * @property {Amount<'nat'> | null} remainingProceedsGoal The remainder of the
+ *   proceeds the sellers were targeting to raise
+ * @property {Amount<'nat'> | undefined} proceedsRaised The proceeds raised so
+ *   far in the auction
+ * @property {Amount<'nat'>} startCollateral How much collateral was available
+ *   for sale at the start. (If more is deposited later, it'll be added in.)
+ * @property {Amount<'nat'> | null} collateralAvailable The amount of collateral
+ *   remaining


Is there another way to get whitespace back here? It very effectively pointed out the parallels in the types, which is now harder to see. (And harder to tell that it was considered salient.)

the tool doesn't do vertical alignment. what parallel is lost?

Note that when this is rendered into HTML it will look like the following. (using default theme)

When I was looking through the changes, it became clear to me that the reformatter thinks that the only version of the comments that matters (not the primary version, the only version) is what gets rendered for readers. I find the comments themselves useful at times to the maintainer (me).

The original formatting (which is what I look at to maintain it) directs my attention to the fact that there is a semantic difference between values which are | null, | undefined, and unadorned. The laid-out version makes that hard to see.

* @typedef {object} BookDataNotification * * @property {Ratio | null} startPrice identifies the priceAuthority and price * @property {Ratio | null} currentPriceLevel the price at the current auction tier * @property {Amount<'nat'> | null} startProceedsGoal The proceeds the sellers were targeting to raise * @property {Amount<'nat'> | null} remainingProceedsGoal The remainder of * the proceeds the sellers were targeting to raise * @property {Amount<'nat'> | undefined} proceedsRaised The proceeds raised so far in the auction * @property {Amount<'nat'>} startCollateral How much collateral was * available for sale at the start. (If more is deposited later, it'll be * added in.) * @property {Amount<'nat'> | null} collateralAvailable The amount of collateral remaining *

ok I understand. There no option to retain the whitespace and I don't expect there will be since one key value of the tool is normalizing whitespace. It doesn't know when it's intentional or accidental. The way to maintain whitespace is to make it a codeblock, but that can't happen within the typedef.

If this is a show-stopped for you, let's discuss higher bandwidth

If this is a show-stopped for you, let's discuss higher bandwidth

Not a show-stopper. On the whole, this is an improvement.

IMO, it may not be enough of an improvement to outweigh the control that it gives up, but I seem to be a minority in that viewpoint. I'm okay with that.

packages/inter-protocol/src/vaultFactory/vault.js

dckc

On the whole, this is an improvement.

concur.

autoformat jsdoc of some packages

dckc reviewed Mar 24, 2022

View reviewed changes

packages/run-protocol/src/vaultFactory/vault.js Outdated Show resolved Hide resolved

This was referenced Mar 24, 2022

auto-format JSDoc comments #4903

Draft

Auto-format jsdoc comments #4900

Open

Chris-Hibbert reviewed Mar 24, 2022

View reviewed changes

turadg force-pushed the 4900-autoformat-jsdoc-run-protocol branch 2 times, most recently from f53503d to e54d855 Compare March 24, 2022 16:21

turadg mentioned this pull request Mar 24, 2022

Remove Prettier from eslint #4339

Open

2 tasks

Chris-Hibbert reviewed Mar 24, 2022

View reviewed changes

turadg commented Mar 24, 2022

View reviewed changes

turadg marked this pull request as ready for review March 24, 2022 23:49

turadg requested review from michaelfig, samsiegart, mhofman, kriskowal and erights as code owners March 24, 2022 23:49

turadg marked this pull request as draft March 24, 2022 23:55

erights approved these changes Mar 25, 2022

View reviewed changes

turadg force-pushed the 4900-autoformat-jsdoc-run-protocol branch from c7f086d to 3944d1d Compare March 30, 2022 19:00

turadg commented Mar 30, 2022

View reviewed changes

mhofman removed their request for review April 21, 2022 17:31

turadg mentioned this pull request May 10, 2022

improve run-protocol types #5336

Merged

kriskowal reviewed Jun 16, 2023

View reviewed changes

turadg force-pushed the 4900-autoformat-jsdoc-run-protocol branch from 3944d1d to afc2132 Compare July 17, 2023 23:18

turadg changed the title ~~autoformat jsdoc of run-protocol package~~ autoformat jsdoc of some packages Jul 17, 2023

dckc reviewed Jul 18, 2023

View reviewed changes

Chris-Hibbert reviewed Jul 18, 2023

View reviewed changes

turadg force-pushed the 4900-autoformat-jsdoc-run-protocol branch from afc2132 to fc69584 Compare July 19, 2023 17:00

turadg requested a review from dckc July 19, 2023 23:04

turadg requested review from erights, Chris-Hibbert, kriskowal and mhofman July 19, 2023 23:04

turadg marked this pull request as ready for review July 19, 2023 23:05

dckc approved these changes Jul 21, 2023

View reviewed changes

turadg added this pull request to the merge queue Jul 21, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 21, 2023

turadg added 7 commits July 20, 2023 18:40

chore(deps): bump eslint-plugin-prettier to v5 release

0843f37

chore: adopt prettier-plugin-jsdoc for inter-protocol package

a366a6d

style: format with jsdoc plugin

9f3fade

style: indent code blocks

961c7f8

chore: adopt prettier-plugin-jsdoc (vats)

48fe179

chore: adopt prettier-plugin-jsdoc (ERTP)

73093eb

style: manual tweaks

f122489

turadg force-pushed the 4900-autoformat-jsdoc-run-protocol branch from 0964816 to f122489 Compare July 21, 2023 01:40

turadg enabled auto-merge July 21, 2023 01:40

turadg added this pull request to the merge queue Jul 21, 2023

Merged via the queue into master with commit 284e2db Jul 21, 2023

turadg deleted the 4900-autoformat-jsdoc-run-protocol branch July 21, 2023 02:37

mhofman pushed a commit that referenced this pull request Aug 7, 2023

Merge pull request #4906 from Agoric/4900-autoformat-jsdoc-run-protocol

cf12a1e

autoformat jsdoc of some packages

		* ACTIVE - vault is in use and can be changed
		* LIQUIDATING - vault is being liquidated by the vault manager, and cannot be changed by the user

		* @property {Ratio} interestRate Annual interest rate charged on loans
		* @property {Ratio} loanFee The fee (in BasisPoints) charged when opening or

		* @param {() => bigint} getProtocolFeeBP - Retrieve governed protocol fee value
		* @param {() => bigint} getPoolFeeBP - Retrieve governed pool fee value

		* }} RunStakePublic
		* To take out a loan, get an `AttestationMaker` for your address from the

		* \| { bidScaling: Pattern; price: undefined }
		* \| { bidScaling: undefined; price: Ratio }

autoformat jsdoc of some packages #4906

autoformat jsdoc of some packages #4906

Conversation

turadg commented Mar 23, 2022 • edited Loading

Description

Security Considerations

Documentation Considerations

Testing Considerations

Chris-Hibbert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turadg Mar 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turadg Mar 24, 2022 • edited Loading

Choose a reason for hiding this comment

turadg commented Mar 24, 2022 • edited Loading

erights left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turadg Mar 25, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turadg commented Mar 26, 2022

Choose a reason for hiding this comment

kriskowal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dckc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dckc left a comment

Choose a reason for hiding this comment

turadg commented Mar 23, 2022 •

edited

Loading

turadg Mar 24, 2022 •

edited

Loading

turadg Mar 24, 2022 •

edited

Loading

turadg commented Mar 24, 2022 •

edited

Loading

turadg Mar 25, 2022 •

edited

Loading