style(run-protocol): @jessie-check for runStake #5148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
added
Zoe
|
I notice the reserve contract has |
turadg
approved these changes
Apr 19, 2022
|
|
||
| // new = after the transaction gets applied | ||
| const newCollateral = addSubtract(collateral, giveColl, wantColl); | ||
| // max debt supported by current Collateral as modified by proposal | ||
| const { amountLiened, maxDebt: newMaxDebt } = | ||
| manager.maxDebtForLien(newCollateral); | ||
|
|
||
| const giveRUN = AmountMath.min(proposal.give[KW.Debt] || emptyDebt, debt); | ||
| const wantRUN = proposal.want[KW.Debt] || emptyDebt; | ||
| const giveRUN = AmountMath.min(proposal.give.Debt || emptyDebt, debt); |
There was a problem hiding this comment.
LGTM.
proposal.give.Attestation looks nicer, but it's a use that is not checked against any defining occurrence.
So now someone could type proposal.give.Debt and get no error, whereas proposal.give[KW.Debte] would have said KW doesn't have that key. But in both cases give doesn't constrain the keys.
I think where we want to get to is that you can validate the proposal with pattern matching so that the type system has a guarantee from some runtime validation as to what's in give. So imo let's work towards that and not invest in the stop-gap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #3788
Zoe API design question: The only part of this code that wasn't already in Jessie was an attempt to have a single-source of truth for keywords in the contract:
proposal.give[KW.Attestation].proposal.give.Attestationlooks nicer, but it's a use that is not checked against any defining occurrence.