Fix bug in fake virtual stuff due to recent liveslots additions #5339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
approved these changes
May 11, 2022
|
This appears to have surfaced another issue that I'm now chasing... |
In support of #5283. @erights and @Chris-Hibbert encountered this in the course of testing their durabilization of ERTP. Note that this bug only implicates tests and not the actual underlying virtual objects implementation.
FUDCo
force-pushed
the
fix-fake-virtual-stuff-version-drift
branch
from
99ccc6a
to
db71bd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of #5283.
This deals with some version drift between liveslots and the fake virtual object mock. The fake virtual object stuff is able to achieve great verisimilitude because it actually uses the real virtual object stuff to do all the virtual object stuff. But it has to fake some stuff from liveslots and that was what was faulty.
@erights and @Chris-Hibbert encountered this in the course of testing their
durabilization of ERTP. Note that this bug only implicates tests and not the
actual underlying virtual objects implementation.