4484 multitenant smart wallet #5721
Conversation
turadg
force-pushed
the
4484-multitenant-smart-wallet
branch
from
d807b03
to
ae2027b
Compare
| */ | ||
| export const provideAsync = async (mapStore, key, makeValue) => { | ||
| if (!mapStore.has(key)) { | ||
| mapStore.init(key, await makeValue(key)); |
There was a problem hiding this comment.
this goes against No Nested Await. Is there any particular justification?
There was a problem hiding this comment.
The introduction of the pending Map doesn't seem equivalent to this. If it's essential, that seems to mean the nested await form was buggy. Anyway... it looks workable, and I'm content that #5728 is where we deal with it definitively.
There was a problem hiding this comment.
The introduction of the pending Map doesn't seem equivalent to this
Right, I wasn't clear. The nested await went away as a side effect of the refactoring to makeAtomicProvider. The need for that function was because of a race condition I encountered when testing multiple wallets. Thanks for suggesting it!
| }, | ||
| }) => { | ||
| const STORAGE_PATH = 'wallet'; | ||
|
|
||
| const storageNode = await getChildNode(chainStorage, STORAGE_PATH); | ||
| const marshaller = E(board).getPublishingMarshaller(); | ||
| const { creatorFacet } = await E(zoe).startInstance( |
There was a problem hiding this comment.
FYI, dropping the admin facet here is not great; but we have plans elsewhere to address it: #4548 (comment)
| return makeChainStorageRoot(toStorage, 'swingset', 'mockChainStorageRoot'); | ||
| }; | ||
|
|
||
| const mockAddress1 = 'mockAddress1'; |
There was a problem hiding this comment.
how about testing 2 or 3 addresses / wallets?
turadg
force-pushed
the
5356-smart-wallet-contract
branch
2 times, most recently
from
d217901
to
80f642b
Compare
turadg
force-pushed
the
4484-multitenant-smart-wallet
branch
from
ae2027b
to
e0309aa
Compare
turadg
force-pushed
the
4484-multitenant-smart-wallet
branch
from
e0309aa
to
57eac62
Compare
refs: #4484
Description
Part of #4484. This doesn't do everything described in that ticket so I'm leaving it to the ticket author to decide what's left, if anything.
Security Considerations
Shared contract amongst all on-chain wallets. Potential DoS attack.
Documentation Considerations
--
Testing Considerations
New tests