-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4968 psm econ data #6013
4968 psm econ data #6013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look closely at the test driver. I'll submit this request while I'm looking that over.
const updateMetrics = () => { | ||
metricsPublication.updateState( | ||
harden({ | ||
poolBalance: anchorPool.getAmountAllocated('Anchor', anchorBrand), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's all we need to recover the state, but the econ committee will also want to know about flows through the system. We should track the amounts that passed through giveStable
and wantStable
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dba9086
to
34863ab
Compare
Everything up to the test file lgtm |
34863ab
to
cbb6b62
Compare
cbb6b62
to
846017a
Compare
846017a
to
6a5d862
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
harden({ | ||
feeMintAccess, | ||
initialPoserInvitation, | ||
storageNode: mockChainStorage.makeChildNode('thisPsm'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in startPSM
the node path is psm.<stable>.<anchor>
. There was no no unit test of startPSM
and this PR doesn't add one. So the test plan includes manually testing on-chain, which is fuller coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah; that's nice...
It prompted me to wonder about other places where our code might assume the PSM, as if there were only one. For example, E(home.agoricNames).lookup('instance', 'psm')
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with input from @btulloh , this seems good to go
closes: #4968
Description
See curated commit history.
Security Considerations
--
Documentation Considerations
Updated README
Testing Considerations
Added unit tests. To cover
startPSM
I also tested manually with cosmic-swingset chain,