store econ committee questions off-chain #6036
Conversation
|
A test showing a question to the econ committee to pause one side of the PSM would be most welcome! |
Well, it turns out that in service of #6007, I'm working on a test showing a governed PSM setting the filter. The existing tests work with a bare PSM that doesn't actually have governance installed AFAICT. (I didn't know that was possible!) |
Nope. I tried to call this state out in Testing Plan.
If that's sufficient: e91c301 |
There was a problem hiding this comment.
I'm sure there are tests in which questions are asked.
If that's sufficient: e91c301
That's what I was looking for, thanks.
turadg
force-pushed
the
ta/store-questions
branch
from
e91c301 to
bc336dc
Compare
| @@ -95,16 +95,25 @@ export const startEconomicCommittee = async ( | |||
| }, | |||
| { options: { econCommitteeOptions = {} } = {} }, | |||
| ) => { | |||
| const STORAGE_PATH = 'committee'; | |||
There was a problem hiding this comment.
This suggests it's the only committee. That's true to some extent, but I wonder to what extent we should commit to that. What do you think about published.committee.economicGovernance or just published.committee1?
There was a problem hiding this comment.
Good call. Updated to be published.committees.Initial_Economic_Committee, sanitizing the committeeName property.
turadg
force-pushed
the
ta/store-questions
branch
from
bc336dc to
e5dc22c
Compare
turadg
force-pushed
the
ta/store-questions
branch
from
e5dc22c to
91dec79
Compare
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Description
Publish committee questions to chain storage.
Security Considerations
Gives contracts a Marshaller from the board. It is read-only.
Documentation Considerations
It's a feature of
@agoric/governancecontracts but also@agoric/inter-protocol. Documented in both READMEs.Testing Considerations
Unit and swingset tests pass, but they don't cover
startEconomicCommittee. So I did a chain test per the "Demo" section of the README. The contract publishes 'undefined' as the first question so the key is present: