6007 test pause PSM #6047
6007 test pause PSM #6047
Conversation
| ).getAmountOf(poserInvitationP); | ||
|
|
||
| /** @type {import('@agoric/vats/tools/storage-test-utils.js').MockChainStorageRoot} */ | ||
| // @ts-expect-error cast |
There was a problem hiding this comment.
you could get this directly from setupPsmBootstrap where it has the type MockChainStorageRoot.
There was a problem hiding this comment.
I don't understand what you're suggesting.
is it a better source for the type info, or calling makeMockChainStorageRoot() here rather than in setupPsmBootstrap?
There was a problem hiding this comment.
in short, better source for the type info. If you exported the value from setupPsmBootstrap then the type would come along with it and you wouldn't need the annotation/cast here.
I think you could call makeMockChainStorageRoot() again here, but I don't see a benefit. It's important that each test have its own chain storage, but each test is calling setupPsm and each of those is calling setupPsmBootstrap.
| * @param {TimerService} timer | ||
| * @param {FarZoeKit} [farZoeKit] | ||
| */ | ||
| export const setupPsmBootstrap = async ( |
There was a problem hiding this comment.
this isn't specific to PSM. I wonder if we can DRY it out with other tests
There was a problem hiding this comment.
It was copied from AMM, and and apparently didn't require any changes. I don't see other contracts that do the same thing, and I don't know how to generalize what's happening. I'd prefer to do the cleanup as a separate task.
| @@ -0,0 +1,62 @@ | |||
| // @ts-check | |||
|
|
|||
| // eslint-disable-next-line import/no-extraneous-dependencies | |||
There was a problem hiding this comment.
is this suppression necessary? @agoric/zoe is declared as a dependency
Chris-Hibbert
force-pushed
the
6007-testPausePsm
branch
from
42e6585 to
2985be8
Compare
Chris-Hibbert
force-pushed
the
5796-governPause
branch
from
d6bba43 to
3193d1a
Compare
Chris-Hibbert
force-pushed
the
6007-testPausePsm
branch
from
2985be8 to
ab3e0a1
Compare
Chris-Hibbert
force-pushed
the
6007-testPausePsm
branch
2 times, most recently
from
94325c2 to
6dd4e21
Compare
Chris-Hibbert
force-pushed
the
6007-testPausePsm
branch
from
8f6c130 to
cc343f5
Compare
refs: #6007
Description
A test showing that governance can set offer filters for the PSM and prevent trading
Changes to contractHelper to get the parameters right in non- and virtual- governorFacets.
Security Considerations
minimal
Documentation Considerations
None
Testing Considerations
This is a mainly test.