-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix process-integration-results.sh #6063
Conversation
Best reviewed commit-by-commit as there is a refactor (move lines around) which clobbers the diff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks
@@ -11,6 +11,10 @@ RESULTSDIR=${RESULTSDIR-"$NETWORK_NAME/results"} | |||
|
|||
[ $# -gt 0 ] && RESULTSDIR="$1" | |||
|
|||
clean_slog() { | |||
jq -cr 'del(.time, .monotime, .dr[2].timestamps, .memoryUsage, .heapStats, .statsTime)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be on the lookout for some kernelStats
that @FUDCo will be adding to one of the cosmic-swingset end-block
slog records, maybe next week, I think some of them are non-consensus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but I believe all of them are actually identical. Regardless they are already written to the swingstore and there is no diff showing up so far ;)
handle corrupted loadgen chain slog
Always generate an artifact, possibly empty if no divergence
ab6d9fe
to
7b5b2e8
Compare
refs: #6022
Description
Updates the processing script to handle some more cases:
Security Considerations
None, manual debug scripts
Documentation Considerations
There should be some
Testing Considerations
Generated artifacts for these divergences in #6011 tests and on a local run of the same branch.