-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vat-data)!: deprecate kinds in favor of Far Classes #6106
Conversation
46b6406
to
171448a
Compare
33b3bd5
to
8741f79
Compare
171448a
to
12dfbe1
Compare
8741f79
to
ab47f04
Compare
12dfbe1
to
ef286d1
Compare
d9469b9
to
e376354
Compare
4765972
to
73086ad
Compare
73086ad
to
c3c754e
Compare
@erights you marked this Ready for Review but the PR description says, "We won't know if this is a good idea until…". Do you think it's a good idea now? |
Good question! You and @Chris-Hibbert have given these more road testing at this point than I have. What do you both think? Are we ready to deprecate kinds in favor of far classes / far instances? |
I don't know enough yet to think we should definitely start on a project to convert everything over, but I prefer Far classes at this point. I'm not sure whether it would be more prudent to finish making Zoe durable using Kinds, rather than mixing the two styles. |
225e877
to
bf4a71a
Compare
bf4a71a
to
0419485
Compare
aa7da76
to
2fe0538
Compare
2fe0538
to
1c2bccf
Compare
440cb4c
to
91eab30
Compare
91eab30
to
3cebc58
Compare
Reviewers (as well as @turadg @michaelfig ), I'd appreciate help in how to deprecate these so that the deprecations show up more reliably under vscode. Thanks. |
The
|
Re #6106 (comment) , Done. |
280c243
to
3252782
Compare
8bb02fe
to
afd4368
Compare
I believe we've now had enough experience with FarClasses, etc, to deprecate the virtual/durable kind APIs and unconditionally recommend FarClasses, etc, instead.