deprecate existing smart-wallet package #6121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
approved these changes
Sep 3, 2022
turadg
force-pushed
the
ta/deprecate-smart-wallet
branch
from
4617192
to
2c39d36
Compare
turadg
added
automerge:rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6084 is a total rewrite of the contract which is not backwards compatible. To land it without having to update everything else in the same PR, we need the new and old to coexist.
The approach taken here is to fork at the package level. It could have been by filenames or directories, but this way has less churn (leaves the files alone) and provides the opportunity to make the smart-wallet package fit the
packages/*scheme.Security Considerations
--
Documentation Considerations
This renames the package but that shouldn't be visible externally. When we publish again the
@agoric/smart-walletpackage will be the new one (with a higher version number, 0.2.0 from 0.1.1). Thelegacy-smart-walletis marked private to not publish.Testing Considerations
CI