Typescript 4.8 #6286
Closed
Typescript 4.8 #6286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
reviewed
Sep 20, 2022
| @@ -88,8 +88,8 @@ export const fsStreamReady = stream => | |||
| * tmpName: typeof import('tmp').tmpName, | |||
| * unlink: typeof import('fs').promises.unlink, | |||
| * }} io | |||
| * @param {object} [options] | |||
| * @param {boolean | undefined} [options.keepSnapshots] | |||
| * @param {object} options | |||
There was a problem hiding this comment.
That seems like a regression, and I've also been hit by this in my own code. There is an explicit init of the options param with = {} so it is actually optional. This really feels like a TS bug. I need to read more on why this is happening.
There was a problem hiding this comment.
Apparently there is already a bug filled on this: microsoft/TypeScript#50286
|
The regression won't be fixed until TS 4.9 so let's skip 4.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade TypeScript 4.7 to 4.8.
https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/
Security Considerations
Documentation Considerations
Testing Considerations