fix: make it possible to set decimalPlaces when calling startPSM #6348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
bug
turadg
approved these changes
Sep 28, 2022
| @@ -79,11 +79,19 @@ export const startPSM = async ( | |||
| E(E(zoe).getInvitationIssuer()).getAmountOf(poserInvitationP), | |||
| ]); | |||
|
|
|||
| const [anchorInfo, stableInfo] = await Promise.all( | |||
There was a problem hiding this comment.
okay. It starts from STABLE.symbol, but I'll rename it locally.
| @@ -79,11 +79,19 @@ export const startPSM = async ( | |||
| E(E(zoe).getInvitationIssuer()).getAmountOf(poserInvitationP), | |||
| ]); | |||
|
|
|||
| const [anchorInfo, stableInfo] = await Promise.all( | |||
| [anchorBrand, stable].map(b => E(b).getDisplayInfo()), | |||
There was a problem hiding this comment.
consider a note about why "display" info is reliable for this use case
There was a problem hiding this comment.
I don't have an answer for that. Can you write something that would justify it?
experience with #6187 makes that look particularly challenging. I can't find any way to diagnose why it works on my desktop and not in ci. |
dckc
approved these changes
Sep 28, 2022
Chris-Hibbert
added a commit
that referenced
this pull request
Sep 29, 2022
* fix: make it possible to set decimalPlaces when calling startPSM * fix: makeRatio wants bigInt * chore: type cleanup and provisioning permit * chore: some tests don't have defaults for anchor decimalPlaces * chore: rename stable token in startPSM to `minted` * fix(agoric-cli): look up correct brand for PSM trade * chore: ignore missing type for pair Co-authored-by: Dan Connolly <connolly@agoric.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Chris-Hibbert
added a commit
that referenced
this pull request
Sep 29, 2022
…) (#6357) * fix: make it possible to set decimalPlaces when calling startPSM * fix: makeRatio wants bigInt * chore: type cleanup and provisioning permit * chore: some tests don't have defaults for anchor decimalPlaces * chore: rename stable token in startPSM to `minted` * fix(agoric-cli): look up correct brand for PSM trade * chore: ignore missing type for pair Co-authored-by: Dan Connolly <connolly@agoric.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dan Connolly <connolly@agoric.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6337
Description
startPSM wasn't setting decimals when creating a new trading pair.
Also,
gov-add-psm.jshad the wrong keywords in its config.Security Considerations
None.
Documentation Considerations
None
Testing Considerations
Manual