-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet-ui): reenable solo-only wallet #6498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me how maintenance of this is intended to work. I suspect there's some rationale for this approach that we would benefit from writing down explicitly.
- build products in the source tree
- old BLD icons
- another copy of lockdown
3cfa040
to
4008b1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow... much cleaner... but now I don't really understand how it works. clue me in?
Here is a draft of what I intend to put in Agoric WalletThis directory contains two Agoric Wallet pieces:
The smart wallet has not yet subsumed all the features of the off-chain wallet. Until it does, we require the The Upgrading the solo wallet UIChange the legacy wallet UI:
Next, you can update the master branch:
After merging the first PR, you can merge the second. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the approach in the README comment looks good!
refs: #6497
Description
Put the built (solo-only) wallet from the
community-dev
branch where theag-solo
web server can find it.Security Considerations
Documentation Considerations
Testing Considerations