fix: triage await safety for swingset #6526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-triage-await-safety-swingset
branch
from
de4063b to
173f452
Compare
erights
force-pushed
the
markm-triage-await-safety-swingset
branch
from
173f452 to
a097e42
Compare
@warner @turadg @gibson042 @Tyrosine22 my apologies. I no longer remember why I thought it was not ready. I need to look again to remind myself. |
|
I remember. This siblings of this PR are listed at #6219 (comment) . For these, most of the await analysis is already done. For this one, I simply ran out of energy. There were too many. |
|
With the simpler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #6219 as agreed at #6219 (comment)
The changes to internals/utils.js are being reviewed separately at #6528 but is included here because the changes in this PR depend on those.
@warner I will ask you to review when it is ready. Not ready yet.