fix(swingset): remove unused worker types: node-subprocess, nodeworker #6890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of our vat workers use `xs-worker`, which runs the code in an `xsnap` subprocess. A handful of vats (maybe just comms) run in a `local` worker, which is co-resident with the kernel. We have two additional worker types, `nodeWorker` (which uses threads, known as "workers" in Node.js), and `node-subprocess` (which runs a second copy of Node.js in a subprocess). I added these for completeness, and to keep us honest about handling different worker types. But they are incomplete (node-subprocess *could* block for a syscall, but I didn't implement that), underfeatured (nodeWorker *cannot* block for a syscall without heroics involving ShareArrayBuffers and Atomics), undertested (the previous lacking features prompted us to `test.skip` them), and unused by anything outside of our test suite. I have refactoring work in the pipeline that will be easier if there is less code to move around. So it's time for these to go. I might try to bring these back some day, but only when we have some interesting use case for them (which is more likely to be inside a browser, than under Node.js). closes #4884
warner
force-pushed
the
4884-remove-unused-workers
branch
from
dd39390 to
bc0722f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of our vat workers use
xs-worker, which runs the code in anxsnapsubprocess. A handful of vats (maybe just comms) run in alocalworker, which is co-resident with the kernel.We have two additional worker types,
nodeWorker(which uses threads, known as "workers" in Node.js), andnode-subprocess(which runs a second copy of Node.js in a subprocess). I added these for completeness, and to keep us honest about handling different worker types. But they are incomplete (node-subprocess could block for a syscall, but I didn't implement that),underfeatured (nodeWorker cannot block for a syscall without heroics involving ShareArrayBuffers and Atomics), undertested (the previous lacking features prompted us to
test.skipthem), and unused by anything outside of our test suite.I have refactoring work in the pipeline that will be easier if there is less code to move around. So it's time for these to go. I might try to bring these back some day, but only when we have some interesting use case for them (which is more likely to be inside a browser, than under Node.js).
closes #4884