feat(inter-protocol): set keyword shares on feeDistributor #6962
Conversation
| // Run once immediately for these destinations. | ||
| await schedulePayments(); | ||
| }, | ||
|
|
||
| /** @param {Record<Keyword, bigint>} newShares */ | ||
| setKeywordShares: newShares => { |
There was a problem hiding this comment.
adding this to the creatorFacet means that it's accessible only to the Builder DAO, right?
There was a problem hiding this comment.
yes; that's the goal of #6926
| /** @param {Record<Keyword, bigint>} newShares */ | ||
| setKeywordShares: newShares => { | ||
| mustMatch(newShares, M.recordOf(M.string(), M.nat())); | ||
| keywordShares = newShares; |
There was a problem hiding this comment.
The original keywordShares is visible in terms. Is there any visibility for the updated value? It could be on the public facet or pushed to chain storage.
There was a problem hiding this comment.
I can put it on the public facet without significant more work.
Rendering the terms out of date / unreliable does seem awkward, but more challenging to address. Gotta think it over a bit.
There was a problem hiding this comment.
I agree that that would be a good goal, but I think we can leave it to address til later.
There was a problem hiding this comment.
I added it to the public facet.
Check for Nat rather than just `bigint` in makeShareConfig(), but also provide `customTermsShape` so that Zoe checks M.nat() before starting the contract.
done. PTAL. |
|
ICYMI: |
closes: #6926
Description
add
setKeywordSharescreator facet method to fee distributor to facilitate adjustment by BLDer DAO.Security Considerations
using
setKeywordShares()can render the contract terms outdated, so they are somewhat unreliable.a
getKeywordShares()method mitigates this somewhat.Scaling Considerations
none?
Documentation Considerations
I suppose there should be some docs to update... I wonder where they are.
Testing Considerations
single happy-path unit test
args have pattern guards, so that seems sufficient