-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auction): add an auctioneer to manage vault liquidation #7000
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0de1e9b
feat(auction): add an auctioneer to manage vault liquiditation
Chris-Hibbert 3d96042
refactor: cleanups from working on vault liquidation
Chris-Hibbert 64ee0bd
chore: cleanups suggested in review
Chris-Hibbert 5a96e6f
refactor: simplify keys in sortOffers
Chris-Hibbert e5ff84d
chore: cosmetic cleanups from review
Chris-Hibbert fcb3056
chore: auction was introduced to vaultfactory too early.
Chris-Hibbert 4d07a53
chore: correctly revert removal of param declaration
Chris-Hibbert c193026
test: repair dependencies for startAuction
Chris-Hibbert 8bed4d5
chore: responses to reviews
Chris-Hibbert d94b6e6
test: refactor proportional distribution test to use macros
Chris-Hibbert 2141de9
refactor: correct sorting of orders by time
Chris-Hibbert bf5e721
chore: cleanups suggested in review
Chris-Hibbert 7150b7e
chore: clean up scheduler; add test for computeRoundTiming
Chris-Hibbert e137415
chore: minor cleanups from review
Chris-Hibbert ea0d0c4
chore: rename auctionKit to auctioneerKit
Chris-Hibbert 7ee7210
chore: drop auction from startPSM
Chris-Hibbert 8d641af
chore: clean-ups from review
Chris-Hibbert 42dd965
refactor: computeRoundTiming should not allow duration === frequency
Chris-Hibbert feda838
chore: clean up governance, add invitation patterns in auctioneer
Chris-Hibbert bfaa587
refactor: don't reschedule next if price is already locked
Chris-Hibbert 5a66425
Merge branch 'master' into 6992-auctioneer
Chris-Hibbert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of scope: consider making buildCopyParam take a shape in the assert/coerce parameter. If it's a function, then it's a coercer and if it's not then it's a shape to match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. #7118