feat(board)!: migrate to smallCaps for boardMarshaller, vstorage, smartWallet

[dckc]

refs: #6822, #6646

Description

An exploration into using smallcaps for the board marshaller and hence vstorage and the smart wallet.

Security Considerations

Clients expecting the @qclass format could get confused.

Scaling Considerations

smallCaps is quite a bit more concise. (#6646 is a nearby optimization)

IOU measurements, I suppose

Documentation Considerations

This represents a burden on clients to support smallCaps.

It also puts a burden on clients that want to read data before this gets deployed to support both formats. I suggest that it's better to put this burden on clients that want to read data from the pre-bulldozer era than migrating after the bulldozer upgrade (#6644).

Testing Considerations

• update test-lib-board.js
• update any smartWallet tests that are sensitive to marshal format
• update dapps / clients that have their own implementation of @agoric/marshal
  • dapp-inter-jumper: Agoric/dapp-inter-jumper@8ac016b#r100912032
  • indexing services?

cc @michaelfig @warner @ivanlei

[erights]

It also puts a burden on clients that want to read data before this gets deployed to support both formats.

Any client that uses marshal unserialize to read the data will already read both formats.

[erights]

I prefer that you not factor this out, but rather repeat the object literal inline in both call sites. The reason is that this is an options bag, and each call site could in theory want to add their own options over time. Think of the options like serializeBodyFormat as approximating name-based parameters as opposed to positional parameters.

[erights]

Do you understand the 2 CI failures?

[dckc]

Do you understand the 2 CI failures?

presumably we got away with not hardening some mocked object but smallCaps is more strict somehow

cd packages/governance && yarn test
...
not ok 53 - unitTests › committee › committee-open question:one %ava-dur=15898ms
          message: 'Cannot pass non-frozen objects like {"iface":"Alleged: ManualTimer"}. Use harden()',

not ok 54 - unitTests › committee › committee-open question:mixed %ava-dur=18120ms
Error#2: Cannot pass non-frozen objects like { iface: 'Alleged: ManualTimer' } . Use harden()

[dckc]

@turadg notes makeAgoricNamesRemotesFromFakeStorage doesn’t undestand smallcaps.

[dckc]

closing in favor of #7565

@warner note makeAgoricNamesRemotesFromFakeStorage and the dapp-inter-jumper thing above.