Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Correct a misspelling of "Remotable" #7217

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

gibson042
Copy link
Member

The supermajority of uses of the term have only two occurrences of "e" (including docs.agoric.com), but there was a deviant.

@gibson042 gibson042 requested review from warner and erights March 22, 2023 19:08
Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Tyrosine22 , Searching, I see there is also an occurrence of "Remoteable" in the documentation repository at https://github.com/Agoric/documentation/blob/0fd4a701f57823d09878754c5b497bfce578107e/main/guides/js-programming/README.md?plain=1#L47

@datadog-full-agoric
Copy link

datadog-full-agoric bot commented Mar 22, 2023

Datadog Report

Branch report: gibson-2023-03-remotable-spelling
Commit report: 57c009a

agoric-sdk: 0 Failed, 0 New Flaky, 3809 Passed, 57 Skipped, 25m 30.11s Wall Time

@gibson042 gibson042 added the automerge:rebase Automatically rebase updates, then merge label Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #7217 (6f277e6) into master (324eee0) will decrease coverage by 8.70%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7217      +/-   ##
==========================================
- Coverage   79.37%   70.68%   -8.70%     
==========================================
  Files         397      450      +53     
  Lines       74856    85567   +10711     
  Branches        3        3              
==========================================
+ Hits        59419    60480    +1061     
- Misses      15436    25021    +9585     
- Partials        1       66      +65     

see 53 files with indirect coverage changes

Impacted file tree graph

@gibson042 gibson042 force-pushed the gibson-2023-03-remotable-spelling branch from a3d0e32 to 6f277e6 Compare March 25, 2023 18:48
@mergify mergify bot merged commit 3c28717 into master Mar 25, 2023
@mergify mergify bot deleted the gibson-2023-03-remotable-spelling branch March 25, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants