7246 fix vaults list #7247
Merged
7246 fix vaults list #7247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
approved these changes
Mar 28, 2023
turadg
force-pushed
the
7246-fix-vaults-list
branch
from
cc51448 to
4725433
Compare
turadg
added
automerge:no-update
Datadog ReportBranch report: ✅ |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7247 +/- ##
==========================================
- Coverage 70.94% 69.04% -1.91%
==========================================
Files 451 376 -75
Lines 86068 74798 -11270
Branches 3 3
==========================================
- Hits 61059 51642 -9417
+ Misses 24941 23090 -1851
+ Partials 68 66 -2
... and 85 files with indirect coverage changes |
turadg
force-pushed
the
7246-fix-vaults-list
branch
from
4725433 to
b3b84dd
Compare
|
@Mergifyio requeue |
☑️ This pull request is already queued |
|
@Mergifyio requeue |
☑️ This pull request is already queued |
|
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #7246
Description
Fixes getting stale
vaults listdata by reading the wrong end of the array at the latest block height.Also refactors rpcUtils to DRY out vstorage deserialization to avoid such errors in the future.
Stacked on #7132
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations