chore: install devnet oracleAddresses
#7386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Apr 11, 2023
| @@ -114,21 +159,27 @@ | |||
| } | |||
| }, | |||
| "bundles": { | |||
There was a problem hiding this comment.
Not crucial, but I would prefer alphabetizing these properties instead of changing between two randomish orderings.
There was a problem hiding this comment.
ok, I can alphabetize the other one instead of mangling this one.
I can't imagine sorting the bundles would destabilize test-vaults-config.
otoole-brendan
approved these changes
Apr 13, 2023
devnet configuration was moving to a smaller set of bootstrap bundles, picking up provisionPool and walletFactory by way of coreProposals. But the test-vaults-config is more widely tested, so until we pick up work on #5819, let's postpone that. - a bit of lint - sort devnet-config bundles to match test-vaults-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs:
Description
oracleAddressesfrom devnet oracle addresses #6950 (comment)Security Considerations
The usual key management considerations around addresses apply.
Scaling, Documentation Considerations
none, AFAICT.
Testing Considerations
devnet is a testing platform