Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7400 governance docs #7402

Merged
merged 5 commits into from
Apr 25, 2023
Merged

7400 governance docs #7402

merged 5 commits into from
Apr 25, 2023

Conversation

turadg
Copy link
Member

@turadg turadg commented Apr 12, 2023

closes: #7400

Description

Refreshes documentation of governance APIs and params in Inter Protocol.

Better would be to have the docs generated from code like #7368 does but this is economical for now.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

docs!

Testing Considerations

nothing automated

@turadg turadg added the bypass:integration Prevent integration tests from running on PR label Apr 12, 2023
@dckc
Copy link
Member

dckc commented Apr 12, 2023

any particular reason to rename the file?

@turadg
Copy link
Member Author

turadg commented Apr 12, 2023

any particular reason to rename the file?

it's now about all governance and not just params. e.g. EC can call governed apis

Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

"invited" would be critical to fix if I could figure out a clearly better alternative.

I think the cost of renaming the file (breaking incoming links) outweighs the benefit of better matching its scope. But I suppose we've reached stalemate on that discussion, and I can live with this.

Comment on lines +109 to +111
| StartingRate | BasisPoints | N/A |
| LowestRate | BasisPoints | N/A |
| DiscountStep | BasisPoints | N/A |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're laying an interpretation NatValue here, should we do likewise for ChargingPeriod, RecordingPeriod above? Those are relative times in seconds, yes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks


Inter Protocol is subject to two forms of governance. Like the entire chain, it's subject to BLDer DAO governance. This is sometimes called the "big hammer" because the DAO can approve running any code in the core ("core eval").

There is also governance by a contract governor contract (see `@agoric/governance`). This allows invited members to execute governed API methods or set governed parameters. In the conventional configuration of the Inter Protocol contracts there is one governing group, which is called the "Economic Committee".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There is also governance by a contract governor contract (see `@agoric/governance`). This allows invited members to execute governed API methods or set governed parameters. In the conventional configuration of the Inter Protocol contracts there is one governing group, which is called the "Economic Committee".
There is also governance by a contract governor contract (see `@agoric/governance`). This allows elected members to execute governed API methods or set governed parameters. In the conventional configuration of the Inter Protocol contracts there is one governing group, which is called the "Economic Committee".

or just strike "invited"... or go with "committee members"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait... this is before we introduce the EC. "This allows a configurable electorate to execute..." would be more precise, though I'm not sure it's much more clear. hm.

"This delegates executing ... and setting ... to a body chosen when the contract is started"?

Copy link
Member Author

@turadg turadg Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good improvements.

Copy link
Contributor

@Chris-Hibbert Chris-Hibbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just getting started, but I ran out of time. I'll take another look next week.

packages/inter-protocol/docs/governance.md Outdated Show resolved Hide resolved
packages/inter-protocol/docs/governance.md Outdated Show resolved Hide resolved
packages/inter-protocol/docs/governance.md Outdated Show resolved Hide resolved
packages/inter-protocol/docs/governance.md Outdated Show resolved Hide resolved
@turadg turadg added the automerge:no-update (expert!) Automatically merge without updates label Apr 25, 2023
@mergify mergify bot merged commit 5052aab into master Apr 25, 2023
@mergify mergify bot deleted the 7400-governance-docs branch April 25, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:no-update (expert!) Automatically merge without updates bypass:integration Prevent integration tests from running on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document governance powers granted to the EC in MN 1B release
3 participants