-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7400 governance docs #7402
7400 governance docs #7402
Conversation
any particular reason to rename the file? |
it's now about all governance and not just params. e.g. EC can call governed apis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
"invited" would be critical to fix if I could figure out a clearly better alternative.
I think the cost of renaming the file (breaking incoming links) outweighs the benefit of better matching its scope. But I suppose we've reached stalemate on that discussion, and I can live with this.
| StartingRate | BasisPoints | N/A | | ||
| LowestRate | BasisPoints | N/A | | ||
| DiscountStep | BasisPoints | N/A | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're laying an interpretation NatValue here, should we do likewise for ChargingPeriod, RecordingPeriod above? Those are relative times in seconds, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks
|
||
Inter Protocol is subject to two forms of governance. Like the entire chain, it's subject to BLDer DAO governance. This is sometimes called the "big hammer" because the DAO can approve running any code in the core ("core eval"). | ||
|
||
There is also governance by a contract governor contract (see `@agoric/governance`). This allows invited members to execute governed API methods or set governed parameters. In the conventional configuration of the Inter Protocol contracts there is one governing group, which is called the "Economic Committee". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also governance by a contract governor contract (see `@agoric/governance`). This allows invited members to execute governed API methods or set governed parameters. In the conventional configuration of the Inter Protocol contracts there is one governing group, which is called the "Economic Committee". | |
There is also governance by a contract governor contract (see `@agoric/governance`). This allows elected members to execute governed API methods or set governed parameters. In the conventional configuration of the Inter Protocol contracts there is one governing group, which is called the "Economic Committee". |
or just strike "invited"... or go with "committee members"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait... this is before we introduce the EC. "This allows a configurable electorate to execute..." would be more precise, though I'm not sure it's much more clear. hm.
"This delegates executing ... and setting ... to a body chosen when the contract is started"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good improvements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just getting started, but I ran out of time. I'll take another look next week.
fdcd4f9
to
c36e03d
Compare
closes: #7400
Description
Refreshes documentation of governance APIs and params in Inter Protocol.
Better would be to have the docs generated from code like #7368 does but this is economical for now.
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
docs!
Testing Considerations
nothing automated