6791 vaults upgrade #7476
Merged
6791 vaults upgrade #7476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
6791-vaults-upgrade
branch
3 times, most recently
from
364c659 to
5330903
Compare
turadg
force-pushed
the
6791-vaults-upgrade
branch
from
789b548 to
039f61d
Compare
turadg
force-pushed
the
6791-vaults-upgrade
branch
2 times, most recently
from
e3f8753 to
d644afe
Compare
turadg
force-pushed
the
6791-upgrade-support
branch
from
000f17d to
d8aacb3
Compare
turadg
force-pushed
the
6791-vaults-upgrade
branch
from
d644afe to
08405c1
Compare
Chris-Hibbert
requested changes
May 2, 2023
Chris-Hibbert
approved these changes
May 2, 2023
turadg
added
automerge:rebase
turadg
force-pushed
the
6791-vaults-upgrade
branch
from
08bbbd0 to
92ea1dd
Compare
turadg
added
the
automerge:no-update
turadg
force-pushed
the
6791-vaults-upgrade
branch
from
92ea1dd to
976d4ef
Compare
no longer a singleton
turadg
force-pushed
the
6791-vaults-upgrade
branch
from
976d4ef to
d73272d
Compare
turadg
force-pushed
the
6791-vaults-upgrade
branch
from
d73272d to
936ea71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6791
Description
Stacked on,
Makes the vaultFactory contract upgradable.
Security Considerations
Governance params aren't yet durable so they will be reset upon contract restart. Any changes by the EC will have to be made again before service.
Scaling Considerations
Some heap improvements. Only one singleton kind now (vaultManagers are now an Exo class kit)
Documentation Considerations
--
Testing Considerations
New bootstrap test. Careful review of test coverage requested. Anything missing?