Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ertp): jessie-check where easy #7487

Merged
merged 1 commit into from
Apr 24, 2023
Merged

refactor(ertp): jessie-check where easy #7487

merged 1 commit into from
Apr 24, 2023

Conversation

erights
Copy link
Member

@erights erights commented Apr 24, 2023 •
edited
Loading

Adds @jessie-check directives to ERTP src/**/*.js files when doing so has zero problems.

See
#3876
#5497
#7486
#7481

@erights erights self-assigned this Apr 24, 2023
dckc
dckc reviewed Apr 24, 2023
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good except...

Staged on #7481

Maybe split out the ERTP-specific part of #7481?

packages/ERTP/src/paymentLedger.js Show resolved Hide resolved
@erights erights force-pushed the markn-ertp-more-jessie-checks branch from d9f3d57 to d524378 Compare April 24, 2023 18:14
@erights erights changed the base branch from markm-errors-sans-new to master April 24, 2023 18:15
@erights erights mentioned this pull request Apr 24, 2023
Merged
@erights
Copy link
Member Author

erights commented Apr 24, 2023

It turns out this PR and #7481 were disjoint, so unstaging.

@erights erights requested a review from dckc April 24, 2023 18:21
@erights erights force-pushed the markn-ertp-more-jessie-checks branch from d524378 to 539ab5d Compare April 24, 2023 19:03
dckc
dckc approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff!

@erights erights added the automerge:rebase Automatically rebase updates, then merge label Apr 24, 2023
@mergify mergify bot merged commit cf84dc7 into master Apr 24, 2023
@mergify mergify bot deleted the markn-ertp-more-jessie-checks branch April 24, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc approved these changes

@Chris-Hibbert Chris-Hibbert Awaiting requested review from Chris-Hibbert

Assignees

@erights erights

Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erights @dckc