feat(xsnap)!: Update to Moddable SDK 3.8.7 #7498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #7083
Refs: agoric-labs/moddable#9, agoric-labs/xsnap-pub#38 (Will be merged first then this PR updated with the resulting commits)
Description
Update to Moddable SDK 3.8.7, the latest published tag
This includes a change to consider WeakRef as strong during organic gc, mitigating #6784.
This includes an upstream change that grows the property map table as needed, affecting some tests.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Updated xsnap tests to handle the property map allocation change (test disabled), and WeakRef change by switching to a
FinalizationRegistry
observer instead.Given the change to WeakRef handling I'm now adapting the acceptance test described in #6929 as follow:
harden
changes that are incompatible with pismo's liveslots)