fix(deploy-script-support): avoid pulling in notifiers #7522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trying to merge #7459 we encountered an error in the loadgen integration test. The deploy script helpers are loaded within a dapp running in RESM mode, and through dependencies in ERTP issuers logic, notifiers was getting pulled in. The new notifier code tried to used syntax unsupported by the
esmpackage (?.), and thus failed to import. The only dependency that deploy script support has on ERTP however is ontoAmountMath, so this changes to a deep import until we can figure out a better cross-repo approach.Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Manually tested to fix the loadgen test issue before the new syntax was reverted.