Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SwingSet): dedupe bundleTool.js with Endo #7596

Merged
merged 1 commit into from
May 3, 2023

Conversation

michaelfig
Copy link
Member

@michaelfig michaelfig commented May 3, 2023

Description

Use Endo's bundle tool infrastructure. This PR was accidentally omitted during the Endo upgrade.

The main feature is that file locking is implemented to prevent bundleTool.js from clobbering bundles made by other processes or async Workers, such as under parallel AVA tests.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

@michaelfig michaelfig self-assigned this May 3, 2023
@michaelfig michaelfig force-pushed the mfig-dedupe-bundle-tool branch from b79b79a to 1aadbaa Compare May 3, 2023 21:22
@michaelfig michaelfig force-pushed the mfig-dedupe-bundle-tool branch from 1aadbaa to 49b01bc Compare May 3, 2023 22:23
@michaelfig michaelfig added SwingSet package: SwingSet tooling repo-wide infrastructure labels May 3, 2023
@michaelfig michaelfig requested a review from turadg May 3, 2023 22:54
@michaelfig michaelfig added the automerge:no-update (expert!) Automatically merge without updates label May 3, 2023
@michaelfig michaelfig requested a review from dckc May 3, 2023 22:55
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah! Wish I'd remembered about this when I ran into the clobbering issue.

I suppose it's worth keeping the cache provider.

@mergify mergify bot merged commit 76a3231 into master May 3, 2023
@mergify mergify bot deleted the mfig-dedupe-bundle-tool branch May 3, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:no-update (expert!) Automatically merge without updates SwingSet package: SwingSet tooling repo-wide infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants