feat(casting): makeHttpClient for explicit net access with cosmjs #7935
Conversation
dckc
force-pushed
the
dc-cosmjs-interpose-net
branch
2 times, most recently
from
cb7154d to
c2716e2
Compare
dckc
force-pushed
the
dc-cosmjs-interpose-net
branch
2 times, most recently
from
7b15a20 to
3a10d1b
Compare
dckc
changed the title
dckc
force-pushed
the
dc-cosmjs-interpose-net
branch
3 times, most recently
from
21b7030 to
3ebb206
Compare
dckc
force-pushed
the
dc-cosmjs-interpose-net
branch
from
3ebb206 to
d7ffad5
Compare
| code: -32601, | ||
| message: 'Method not found', | ||
| }, | ||
| id: 1, |
There was a problem hiding this comment.
This id should match the one on line 18 it is replying to, in order to conform to the JSON-RPC response object spec.
| }, | ||
| ]), | ||
| { | ||
| id: 2, |
There was a problem hiding this comment.
This, too, should match the body.id above.
| }, | ||
| ]), | ||
| { | ||
| id: 753972443441, |
|
I haven't looked closely yet but regarding the recording have you considered something off the shelf? Eg https://github.com/nock/nock#recording |
I didn't; I don't expect to find anything comparable. That is: ~100 lines and no use of ambient authority. nock is clearly >>100 lines. I don't see any support for explicit rather than ambient authority. |
- test: query using generated vstorage stubs - captureIO test utility - net access fixture
dckc
force-pushed
the
dc-cosmjs-interpose-net
branch
from
7ae4130 to
dd56704
Compare
feat(casting): makeHttpClient for explicit net access with cosmjs
refs: #7905
stacked on #7950
Description
makeHttpClientis an alternative to the cosmjs HttpClient that uses explicit rather than ambient access to the network.Security Considerations
facilitates use within a
Compartment, for example.In due course, I'd like other relevant APIs in the casting package to allow passing in network access likewise.
Scaling / Documentation Considerations
n/a
Testing Considerations
Also includes
captureIOandreplayIOtest utilities to wrapfetch, record the traffic as fixtures, and then replay it from those fixtures.