use TS satisfies #8032
Merged
use TS satisfies #8032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
approved these changes
Jul 11, 2023
| * brand: import('@agoric/internal/src/marshal.js').BoardRemote & Brand, | ||
| * brand: import('@agoric/internal/src/marshal.js').BoardRemote, |
There was a problem hiding this comment.
Comment on lines
12
to
14
| // NB: not really a Proposal because the brands are not remotes | ||
| // Instead they're copyRecord like "{"boardId":"board0257","iface":"Alleged: IST brand"}" to pass through the boardId | ||
| // mustMatch(harden(proposal), ProposalShape); |
There was a problem hiding this comment.
This NB: is no longer the case, is it? makeBoardRemote uses Far. The change to smallcaps made it necessary, IIRC.
| @@ -373,6 +369,9 @@ const makePushPriceOffer = (_agoricNames, opts, previousOffer) => { | |||
| }; | |||
| }; | |||
|
|
|||
| /** | |||
| * @satisfies {Record<string, Record<string, import('@agoric/smart-wallet/src/types.js').OfferMaker>>} | |||
There was a problem hiding this comment.
TIL:
satisfiesmakes sure a value's type matches some type shape, but doesn't widen the type unnecessarily.
anilhelvaci
pushed a commit
to anilhelvaci/agoric-sdk
that referenced
this pull request
Aug 16, 2023
This PR removes the following lint warnings introduced by version update of eslint-plugin-jsdoc in Agoric#8032. (jsdoc/no-defaults) Defaults are not permitted on @param
anilhelvaci
pushed a commit
to Jorge-Lopes/agoric-sdk
that referenced
this pull request
Feb 16, 2024
This PR removes the following lint warnings introduced by version update of eslint-plugin-jsdoc in Agoric#8032. (jsdoc/no-defaults) Defaults are not permitted on @param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes use of
@satisfiesfor the OfferMaker lookup in clientSupport. Also bumps deps to support it.See https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#satisfies-support-in-jsdoc
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
CI