more ts syntax

.eslintrc.cjs

@@ -164,5 +164,19 @@ module.exports = {
         '@jessie.js/safe-await-separator': 'off',
       },
     },
+    {
+      // Types files have no promises to lint and that linter chokes on the .d.ts twin.
+      // Maybe due to https://github.com/typescript-eslint/typescript-eslint/issues/7435
+      files: ['types*.js'],
+      rules: {
+        // Disabled to prevent:
+        //         Error: Error while loading rule '@typescript-eslint/no-floating-promises': You have used a rule which requires parserServices to be generated. You must therefore provide a value for the "parserOptions.project" property for @typescript-eslint/parser.
+        // Occurred while linting ~agoric-sdk/packages/vats/src/core/types.js
+        //     at Object.getParserServices (~agoric-sdk/node_modules/@typescript-eslint/utils/dist/eslint-utils/getParserServices.js:24:15)
+        //     at create (~agoric-sdk/node_modules/@typescript-eslint/eslint-plugin/dist/rules/no-floating-promises.js:77:31)
+        //     at Object.create (~agoric-sdk/node_modules/@typescript-eslint/utils/dist/eslint-utils/RuleCreator.js:38:20)
+        '@typescript-eslint/no-floating-promises': 'off',
+      },
+    },
   ],
 };

packages/boot/index.js

@@ -1,3 +1,3 @@
 // @ts-check
 // Ambient types
-import '@agoric/vats/src/core/types.js';
+import '@agoric/vats/src/core/types-ambient.js';

packages/deploy-script-support/test/unitTests/test-coreProposalBehavior.js

@@ -2,7 +2,7 @@
 import { test } from '@agoric/zoe/tools/prepare-test-env-ava.js';
 
 import { E } from '@endo/far';
-import '@agoric/vats/src/core/types.js';
+import '@agoric/vats/src/core/types-ambient.js';
 import {
   makeAgoricNamesAccess,
   runModuleBehaviors,

packages/inter-protocol/test/smartWallet/boot-test-utils.js

@@ -19,7 +19,6 @@ const { Fail } = assert;
 export const noop = () => {};
 
 /** @type {DProxy} */
-// @ts-expect-error cast
 export const mockDProxy = d => d;
 
 export const makeMock = log =>

packages/inter-protocol/test/smartWallet/test-oracle-integration.js

@@ -1,4 +1,4 @@
-import '@agoric/vats/src/core/types.js';
+import '@agoric/vats/src/core/types-ambient.js';
 
 import { test as anyTest } from '@agoric/zoe/tools/prepare-test-env-ava.js';
 

packages/inter-protocol/test/smartWallet/test-psm-integration.js

@@ -1,7 +1,7 @@
 import { test as anyTest } from '@agoric/zoe/tools/prepare-test-env-ava.js';
 
 import { AmountMath, makeIssuerKit } from '@agoric/ertp';
-import '@agoric/vats/src/core/types.js';
+import '@agoric/vats/src/core/types-ambient.js';
 import { eventLoopIteration } from '@agoric/internal/src/testing-utils.js';
 import { E } from '@endo/far';
 import { NonNullish } from '@agoric/assert';

packages/smart-wallet/src/invitations.js

@@ -59,7 +59,7 @@ const MAX_PIPE_LENGTH = 2;
 
 /**
  * @param {ERef<ZoeService>} zoe
- * @param {ERef<NameHub>} agoricNames
+ * @param {ERef<import('@agoric/vats').NameHub>} agoricNames
  * @param {Brand<'set'>} invitationBrand
  * @param {Purse<'set'>} invitationsPurse
  * @param {(fromOfferId: string) => import('./types').InvitationMakers} getInvitationContinuation

packages/smart-wallet/src/proposals/upgrade-walletFactory-proposal.js

@@ -90,7 +90,7 @@ export const publishAgoricBrandsDisplayInfo = async ({
     await E(node).setValue(JSON.stringify(aux));
   };
 
-  /** @type {ERef<NameHub>} */
+  /** @type {ERef<import('@agoric/vats').NameHub>} */
   const brandHub = E(agoricNames).lookup('brand');
   const brands = await E(brandHub).values();
   // tolerate failure; in particular, for the timer brand

packages/smart-wallet/src/smartWallet.js

@@ -160,7 +160,7 @@ const trace = makeTracer('SmrtWlt');
  * TODO: consider moving to nameHub.js?
  *
  * @param {unknown} target - passable Key
- * @param {ERef<NameHub>} nameHub
+ * @param {ERef<import('@agoric/vats').NameHub>} nameHub
  */
 const namesOf = async (target, nameHub) => {
   const entries = await E(nameHub).entries();
@@ -447,7 +447,7 @@ export const prepareSmartWallet = (baggage, shared) => {
          * to facilitate a transition to decentralized introductions.
          *
          * @param {Brand} brand
-         * @param {ERef<NameHub>} known - namehub with brand, issuer branches
+         * @param {ERef<import('@agoric/vats').NameHub>} known - namehub with brand, issuer branches
          * @returns {Promise<Purse | undefined>} undefined if brand is not known
          */
         async getPurseIfKnownBrand(brand, known) {

packages/smart-wallet/test/supports.js

@@ -11,7 +11,7 @@ import {
   makeBoard,
 } from '@agoric/vats/src/core/basic-behaviors.js';
 import { setupClientManager } from '@agoric/vats/src/core/chain-behaviors.js';
-import '@agoric/vats/src/core/types.js';
+import '@agoric/vats/src/core/types-ambient.js';
 import { buildRootObject as boardRoot } from '@agoric/vats/src/vat-board.js';
 import { buildRootObject as mintsRoot } from '@agoric/vats/src/vat-mints.js';
 import { makeFakeBankKit } from '@agoric/vats/tools/bank-utils.js';

packages/smart-wallet/test/test-startWalletFactory.js

@@ -6,7 +6,7 @@ import { E } from '@endo/far';
 import path from 'path';
 import { makeMockTestSpace } from './supports.js';
 
-import '@agoric/vats/src/core/types.js';
+import '@agoric/vats/src/core/types-ambient.js';
 
 /** @type {import('ava').TestFn<Awaited<ReturnType<typeof makeTestContext>>>} */
 const test = anyTest;

packages/smart-wallet/test/test-walletFactory.js

@@ -11,7 +11,7 @@ import {
   topicPath,
 } from './supports.js';
 
-import '@agoric/vats/src/core/types.js';
+import '@agoric/vats/src/core/types-ambient.js';
 
 /** @type {import('ava').TestFn<Awaited<ReturnType<makeDefaultTestContext>>>} */
 const test = anyTest;

packages/vats/exported.js

@@ -1 +1 @@
-import './src/core/types.js';
+import './src/core/types-ambient.js';

packages/vats/index.js

@@ -1,7 +1,7 @@
 // @ts-check
 // Ambient types
 import '@agoric/zoe/exported.js';
-import './src/core/types.js';
+import './src/core/types-ambient.js';
 
 // eslint-disable-next-line import/export -- no named exports
 export * from './src/types.js';

packages/vats/src/bridge.js

@@ -3,7 +3,7 @@
 import { M } from '@agoric/store';
 import '@agoric/store/exported.js';
 import { E } from '@endo/far';
-import './core/types.js';
+import './core/types-ambient.js';
 
 const { Fail, details: X } = assert;
 

packages/vats/src/core/chain-behaviors.js

@@ -363,6 +363,7 @@ export const makeChainStorage = async ({
   if (!bridgeManager) {
     console.warn('Cannot support chainStorage without an actual chain.');
     chainStorageP.resolve(null);
+    // @ts-expect-error expects value or undefined
     storageBridgeManagerP.resolve(null);
     return;
   }