test: remove tmux from upgrade-tests #8393
Conversation
use `exec -it` to get a shell
|
Wondering if we could make exec into a the running container easier by having a |
Co-authored-by: Ikenna Omekam <ikenna@agoric.com>
I'm also for easier. I was reluctant to put more into the |
| @@ -74,4 +69,7 @@ run_test: | |||
| run_bash: | |||
| $(RUN) --entrypoint /bin/bash $(REPOSITORY):$(dockerLabel) | |||
|
|
|||
| shell: | |||
| docker exec -it `docker ps --latest --format json | jq -r .Names` bash | |||
There was a problem hiding this comment.
A possible alternative here could be something like:
docker exec -ti $(docker ps -q -f ancestor=agoric/upgrade-test:agoric-upgrade-11) bash
Where you replace agoric-upgrade-11 with TARGET similar to other commands. This way you always target the correct container, and not one launched after you did make run (e.g. vscode devcontainer or something).
There was a problem hiding this comment.
latest is a problem for me, I'm a heavy docker user and this definitely might not be my latest container
There was a problem hiding this comment.
I figure latest will be what most people want and those who don't (because they use Docker extensively) are sophisticated enough to something else.
Thanks for the simpler way to get the container name, @raphdev . I looked but didn't find it.
I don't think we want to hard-code the ancestor, because it's something to have to remember to change and it's not always the target wanted.
this works,
shell:
docker exec -it `docker ps -q -f ancestor=agoric/upgrade-test:$(TARGET)` bash
but then it requires the user to specify the target.
There was a problem hiding this comment.
we can always iterate on this if/when it becomes a problem
test: remove tmux from upgrade-tests
test: remove tmux from upgrade-tests
refs: #8361
Description
While iterating on #8361, tmux was more hindrance than help. It truncated the scrollback and made viewing it difficult.
The primary purpose of the tests is to run the chain and succeed/fail. Thus the entrypoint should be the chain runner. Docker makes it easy to attach a shell to a running container, so instead of complicating the entrypoint we should just use that. (Now documented in the README)
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
Not outside this repo
Testing Considerations
--
Upgrade Considerations
n/a