feat(ERTP): Make recoverySets optional #8406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-recovery-sets-optional
branch
from
38c47ae to
5519cdb
Compare
erights
commented
Sep 28, 2023
Comment on lines
+129
to
+150
| // NOTE: Schema change! | ||
| recoverySet: M.opt(M.remotable('recoverySet')), |
There was a problem hiding this comment.
Reviewers,
NOTE: Schema change!
What should we actually do about this?
erights
commented
Sep 28, 2023
| const paymentRecoverySets = | ||
| recoverySetOption === 'noRecoverySets' | ||
| ? undefined | ||
| : provideDurableWeakMapStore(issuerBaggage, 'paymentRecoverySets'); | ||
|
|
There was a problem hiding this comment.
What if the revived issuer has 'noRecoverySets' but the old state has recovery sets?
FUDCo
reviewed
Sep 28, 2023
erights
force-pushed
the
markm-recovery-sets-optional
branch
from
5519cdb to
2d5c300
Compare
erights
force-pushed
the
markm-recovery-sets-optional
branch
from
2d5c300 to
cafb065
Compare
erights
changed the base branch from
master
to
markm-kill-some-dead-type-decls
erights
force-pushed
the
markm-recovery-sets-optional
branch
2 times, most recently
from
9eb3636 to
ead568a
Compare
erights
force-pushed
the
markm-recovery-sets-optional
branch
from
ead568a to
dc6e0f6
Compare
9 tasks
|
Closing in favor of #8418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO explain
Staged on #8414