test adding stATOM collateral by fetching proposer's bundles #8454

dckc · 2023-10-13T06:04:44Z

stacked on #8436

Upgrade Considerations

@turadg , since this environment has contract bundles that match mainnet1B-bundle-ids.md, it seems important to use this framework to check that the proposal doesn't replace agoricNames.installation.priceAggregator with a new bundle.

priceAggregator, scaledPriceAuthority contracts are already installed 0xpatrickdev/agoric-vault-collateral-proposal#7

root@a5ec8f960285:/usr/src/agoric-sdk/upgrade-test-scripts# sqlite3 ~/.agoric/data/agoric/swingstore.sqlite '.mode column' '.header on' "select bundleId from bundles where (bundleId like 'b1-4522b%' or bundleId like 'b1-0b217%')"
bundleID                                                                                                                           
-----------------------------------------------------------------------------------------------------------------------------------
b1-0b2177975e88c7221b2fe635fdc75f518916ee42d959e9772dc77ef9775995f36cef50578a070708606e2c2431e66ee51d01147b10821aa5f1983e564697cccd
b1-4522bd0b71b615b612235d321977a1e906cd289e0962b106e7ba5718d0e94e25bc2c9e4be589c513c05c337c25a0c89c527b91322415cc80337fb2b2b0ccb75a

Description

closes: #8177
(well, maybe not, but I want to make the link prominent)

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

- WIP: symlink mode - WIP: lots of debug logging

…pond" This reverts commit 72586d7.

- no permit - no observed change

dckc · 2023-10-13T18:35:51Z

working pretty well...
72d1398

connolly@bldbox:~/projects/agoric-sdk/packages/deployment/upgrade-test$ MN2=/tmp make run_bash
docker run --rm -it -p 26656:26656 -p 26657:26657 -p 1317:1317 -v "${PWD}:/workspace" -v "${MN2}:/mn2" -e "DEBUG=SwingSet:ls,SwingSet:vat" --entrypoint /bin/bash agoric/upgrade-test:agoric-upgrade-12
ENV_SETUP starting
ENV_SETUP finished
root@caca76fd4983:/usr/src/agoric-sdk# ln -s /workspace/dev.mk Makefile
root@caca76fd4983:/usr/src/agoric-sdk# make start
agd start --log_level=warn >,chain.log 2>&1 &
root@caca76fd4983:/usr/src/agoric-sdk# make link-work
mv upgrade-test-scripts x-scripts
ln -s /workspace/upgrade-test-scripts
root@caca76fd4983:/usr/src/agoric-sdk# cd upgrade-test-scripts
root@caca76fd4983:/usr/src/agoric-sdk/upgrade-test-scripts# yarn ava agoric-upgrade-11/add-collateral.test.js 
yarn run v1.22.19
warning package.json: No license field
$ /workspace/upgrade-test-scripts/node_modules/.bin/ava agoric-upgrade-11/add-collateral.test.js

  - [todo] manager in vstorage
  - [todo] price feed in vstorage - after setting prices
  - [todo] create a vault as dapp-inter does
bundleAssets: https://github.com/dckc/agoric-vault-collateral-proposal/releases/download/v0.13.0-beta1/ -> /tmp/assets-272-cNlHp1jFu50r
XXX is sync IO essential?
  ✔ bundles not yet installed
    ℹ add-stATOM.js 1 eval 1 bundles
    ℹ b1-903e41a7c448a41b456298404a1c32c69302574209c6a5228723ed19e2dd99f2a693641196445bc27a90e19e1dfadfe6b3d9c9a93f080ffa33a70908e5af4fff not in 45 loaded bundles ?
    ℹ add-stATOM-oracles.js 1 eval 1 bundles
    ℹ b1-80e6fe68b299c82c2d26802c312bc37966a559f7b28f87d058887a79a9db48ad97da2240e71e3f98986071da8fc3c5d02358bec577b17a89cee2b1cb3cd23958 not in 45 loaded bundles ?
WebRd fetch: https://github.com/dckc/agoric-vault-collateral-proposal/releases/download/v0.13.0-beta1/b1-903e41a7c448a41b456298404a1c32c69302574209c6a5228723ed19e2dd99f2a693641196445bc27a90e19e1dfadfe6b3d9c9a93f080ffa33a70908e5af4fff.json
XXX: rpcAddrs after [0] are ignored
XXX: rpcAddrs after [0] are ignored
WebRd fetch: https://github.com/dckc/agoric-vault-collateral-proposal/releases/download/v0.13.0-beta1/b1-80e6fe68b299c82c2d26802c312bc37966a559f7b28f87d058887a79a9db48ad97da2240e71e3f98986071da8fc3c5d02358bec577b17a89cee2b1cb3cd23958.json
  ✔ bundle names: compartmentMap.entry (1.8s)
    ℹ {
        compartment: '@agoric/inter-protocol-v0.16.1',
        module: './src/proposals/addAssetToVault.js',
      } b1-903e4
    ℹ {
        compartment: '@agoric/inter-protocol-v0.16.1',
        module: './src/proposals/price-feed-proposal.js',
      } b1-80e6f
WebRd fetch: https://github.com/dckc/agoric-vault-collateral-proposal/releases/download/v0.13.0-beta1/add-stATOM-permit.json
WebRd fetch: https://github.com/dckc/agoric-vault-collateral-proposal/releases/download/v0.13.0-beta1/add-stATOM-oracles-permit.json
  ✔ core eval not permitted to add/replace installations (447ms)
    ℹ installation.produce undefined add-stATOM-permit.json
    ℹ installation.produce undefined add-stATOM-oracles-permit.json
  ✔ save installations before the poposal (2s)
    ℹ {
        boardID: 'board02021',
        iface: 'Alleged: BundleIDInstallation',
      }
  ✔ ensure enough IST to install bundles (3s)
    ℹ {
        cost: 4735.948,
        totalSize: 2367974,
      }
    ℹ {
        wantMinted: 4722,
      }

xxx


        wantMinted: 4722,
      }
@@TODO: prevent agoric follow hang  bundles
gas estimate: 46127633
gas estimate: 31628278
@@TODO: prevent agoric follow hang  bundles
  ✔ ensure bundles installed (2.8s)
    ℹ {
        code: 0,
        gas_used: '46124623',
        height: '758',
        txhash: 'D3D06B68ED52E9B765953E217D05381043D1188F535B9D87BE7DEAB489A0CADC',
      }
    ℹ {
        endoZipBase64Sha512: '903e41a7c448a41b456298404a1c32c69302574209c6a5228723ed19e2dd99f2a693641196445bc27a90e19e1dfadfe6b3d9c9a93f080ffa33a70908e5af4fff',
        error: null,
        installed: true,
      }
    ℹ {
        code: 0,
        gas_used: '31625268',
        height: '759',
        txhash: '02CE97BCE11C7EF4618FD35111C2C9C940B00715E14E182E1D3D2A819BBC47EE',
      }
    ℹ {
        endoZipBase64Sha512: '80e6fe68b299c82c2d26802c312bc37966a559f7b28f87d058887a79a9db48ad97da2240e71e3f98986071da8fc3c5d02358bec577b17a89cee2b1cb3cd23958',
        error: null,
        installed: true,
      }
WebRd fetch: https://github.com/dckc/agoric-vault-collateral-proposal/releases/download/v0.13.0-beta1/add-stATOM.js
WebRd fetch: https://github.com/dckc/agoric-vault-collateral-proposal/releases/download/v0.13.0-beta1/add-stATOM-oracles.js
gas estimate: 2160117
1
block produced
1
block produced
1
block produced
Waiting for proposal 6 to pass (status=PROPOSAL_STATUS_VOTING_PERIOD)
1
block produced
Waiting for proposal 6 to pass (status=PROPOSAL_STATUS_VOTING_PERIOD)
1
block produced
Waiting for proposal 6 to pass (status=PROPOSAL_STATUS_VOTING_PERIOD)
1
block produced
Waiting for proposal 6 to pass (status=PROPOSAL_STATUS_VOTING_PERIOD)
1
block produced
Waiting for proposal 6 to pass (status=PROPOSAL_STATUS_VOTING_PERIOD)
1
block produced
Waiting for proposal 6 to pass (status=PROPOSAL_STATUS_VOTING_PERIOD)
1
block produced
Waiting for proposal 6 to pass (status=PROPOSAL_STATUS_VOTING_PERIOD)
1
block produced
Waiting for proposal 6 to pass (status=PROPOSAL_STATUS_PASSED)
1
block produced
  ✔ core eval proposal passes (13.2s)
    ℹ submit proposal agoric-vault-collateral-proposal
    ℹ {
        code: 0,
        gas_used: '1797088',
        height: '761',
        txhash: '9F8811F5D378C07C4148F9CC2581EF2C301F19341791C363FB8D4F383EBA6703',
      }
    ℹ 6 2023-10-13T18:30:46.791938090Z PROPOSAL_STATUS_PASSED
  ✔ priceAuthority installation was not changed (2.1s)
    ℹ {
        actual: {
          boardID: 'board02021',
          iface: 'Alleged: BundleIDInstallation',
        },
        expected: {
          boardID: 'board02021',
          iface: 'Alleged: BundleIDInstallation',
        },
      }
  ✘ [fail]: stATOM-USD price feed instance in agoricNames
    ℹ stATOM-USD price feed in 17 instance ?
  ─

  stATOM-USD price feed instance in agoricNames
  agoric-upgrade-11/add-collateral.test.js:339

   338:   const { instance } = await wellKnownIdentities({ agoric });                 
   339:   testIncludes(t, 'stATOM-USD price feed', Object.keys(instance), 'instance');
   340: });                                                                           

  Difference (- actual, + expected):

    [
  +   'stATOM-USD price feed',
    ]

  › testIncludes (file://agoric-upgrade-11/core-eval-support.js:40:7)
  › file://agoric-upgrade-11/add-collateral.test.js:339:3

  ─

  1 test failed
  3 tests todo
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
root@caca76fd4983:/usr/src/agoric-sdk/upgrade-test-scripts# yarn ava agoric-upgrade-11/add-collateral.test.js -m '*instance in agoricNames'
yarn run v1.22.19
warning package.json: No license field
$ /workspace/upgrade-test-scripts/node_modules/.bin/ava agoric-upgrade-11/add-collateral.test.js -m '*instance in agoricNames'

bundleAssets: https://github.com/dckc/agoric-vault-collateral-proposal/releases/download/v0.13.0-beta1/ -> /tmp/assets-1115-MfKj5sudkty7
XXX is sync IO essential?
XXX: rpcAddrs after [0] are ignored
XXX: rpcAddrs after [0] are ignored
  ✔ stATOM-USD price feed instance in agoricNames (2s)
    ℹ stATOM-USD price feed in 19 instance ?
  ─

  1 test passed
Done in 3.09s.

dckc · 2024-01-19T19:48:09Z

obsolete in favor of https://github.com/Agoric/agoric-3-proposals/tree/main/proposals/55%3Astatom-vaults (24a16f3 or before)

dckc and others added 9 commits October 13, 2023 06:57

test: add vault collateral by fetching assets from contributor (WIP)

11bb559

- WIP: symlink mode - WIP: lots of debug logging

build: add tmp dep in chain upgrade-test

96fcc67

chore(webAsset): fail on 404

6d3e491

chore(add-collateral.test): clean up some logging

bdeb7f2

test(add-collateral): price feed instance in agoricNames

7fed677

feat: addAssetToVault must wait for the priceAuthority to respond

be58e78

Revert "feat: addAssetToVault must wait for the priceAuthority to res…

783e2b8

…pond" This reverts commit 72586d7.

chore: include installation in wellKnownIdentities

2108f48

test(add-collateral): no change to agoricNames.installation

4997d09

- no permit - no observed change

dckc force-pushed the 8177-mcs-by-ref branch from fda1019 to 4997d09 Compare October 13, 2023 11:57

dckc added 4 commits October 13, 2023 09:57

chore: nicer webAsset diagnostic

5fab787

build: add @endo/zip

23fdc0d

test: bundle entry, installation permit; release org (WIP)

b160c3e

chore: testing beta1 release working pretty well

72d1398

dckc changed the base branch from master to 8376-mn2-fetch October 13, 2023 18:37

dckc mentioned this pull request Oct 13, 2023

test stATOM proposal in CI using an upgrade test #8177

Closed

dckc mentioned this pull request Oct 26, 2023

WIP: stATOM, KREAd proposal tests Agoric/agoric-3-proposals#3

Closed

dckc closed this Jan 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test adding stATOM collateral by fetching proposer's bundles #8454

test adding stATOM collateral by fetching proposer's bundles #8454

dckc commented Oct 13, 2023 •

edited

Loading

dckc commented Oct 13, 2023 •

edited

Loading

dckc commented Jan 19, 2024

test adding stATOM collateral by fetching proposer's bundles #8454

test adding stATOM collateral by fetching proposer's bundles #8454

Conversation

dckc commented Oct 13, 2023 • edited Loading

Upgrade Considerations

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

dckc commented Oct 13, 2023 • edited Loading

dckc commented Jan 19, 2024

dckc commented Oct 13, 2023 •

edited

Loading

dckc commented Oct 13, 2023 •

edited

Loading