fix(solo): properly expose /wallet/bridge.html
#8533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
approved these changes
Nov 15, 2023
| ); | ||
| } else { | ||
| app.get('/wallet/bridge.html', (_, res) => | ||
| res.sendFile(path.resolve(soloHtmlDir, 'wallet-bridge.html')), |
There was a problem hiding this comment.
Why not redirect to wallet-bridge.html ?
There was a problem hiding this comment.
No redirect because I want /wallet/bridge.html to be canonical.
michaelfig
added
the
automerge:no-update
michaelfig
force-pushed
the
mfig-getting-started
branch
from
4653fc9 to
4fee8e5
Compare
michaelfig
force-pushed
the
mfig-getting-started
branch
from
4fee8e5 to
ac04f8b
Compare
michaelfig
added
automerge:squash
michaelfig
added a commit
that referenced
this pull request
Nov 16, 2023
mhofman
pushed a commit
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't send
/wallet/index.htmlwhen/wallet/bridge.htmlwas requested.Makes solo wallet compatible with
@agoric/web-componentsagain.Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
Tested manually with fungible faucet
Upgrade Considerations
n/a