Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake virtual watched promises for upgrade 14 #8772

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

Chris-Hibbert
Copy link
Contributor

refs: #8661

Description

Copies #8661 (repairs tests to support watchedPromises) to the upgrade-14 branch

Security Considerations

N/A

Scaling Considerations

N/a

Documentation Considerations

N/A

Testing Considerations

Repairs tests for a crucial feature

Upgrade Considerations

... for upgrade-14

@Chris-Hibbert Chris-Hibbert self-assigned this Jan 18, 2024
@Chris-Hibbert Chris-Hibbert requested a review from mhofman January 18, 2024 21:21
@mhofman mhofman added the force:integration Force integration tests to run on PR label Jan 19, 2024
Copy link
Member

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that this is a straightforward cherry-pick of #8618.

Not approving yet until the final dev-upgrade-14 branch is ready, at which point we'll need to rebase this PR on top of it.

@mhofman mhofman requested a review from gibson042 January 19, 2024 02:22
* test: support for watchedPromises in fakeVirtualSupport

Needed by #8488

* chore: update allocatePromiseID to use nextExportID

* chore: distinct ID range for proises
@mhofman mhofman changed the base branch from tmp-upgrade-14 to dev-upgrade-14 January 19, 2024 18:29
@mhofman mhofman force-pushed the 8618-fakeVirtual-watchedPromises-14 branch from f31ccb0 to c02c973 Compare January 19, 2024 18:30
@mhofman mhofman merged commit 5ef517d into dev-upgrade-14 Jan 19, 2024
63 checks passed
@mhofman mhofman deleted the 8618-fakeVirtual-watchedPromises-14 branch January 19, 2024 19:04
anilhelvaci pushed a commit to Jorge-Lopes/agoric-sdk that referenced this pull request Mar 4, 2024
…ic#8772)

* test: support for watchedPromises in fakeVirtualSupport

Needed by Agoric#8488

* chore: update allocatePromiseID to use nextExportID

* chore: distinct ID range for proises
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants